Rename some class from Impl to Default
This commit is contained in:
parent
cf4497d323
commit
45598a885e
26 changed files with 59 additions and 58 deletions
|
|
@ -37,7 +37,7 @@ import java.util.UUID
|
|||
import javax.inject.Inject
|
||||
|
||||
@ContributesBinding(AppScope::class)
|
||||
class PickerProviderImpl(private val isInTest: Boolean) : PickerProvider {
|
||||
class DefaultPickerProvider(private val isInTest: Boolean) : PickerProvider {
|
||||
@Inject
|
||||
constructor() : this(false)
|
||||
|
||||
|
|
@ -43,7 +43,7 @@ import kotlin.time.Duration.Companion.seconds
|
|||
*/
|
||||
@ContributesBinding(RoomScope::class)
|
||||
@SingleIn(RoomScope::class)
|
||||
class MediaPlayerImpl @Inject constructor(
|
||||
class DefaultMediaPlayer @Inject constructor(
|
||||
private val player: SimplePlayer,
|
||||
) : MediaPlayer {
|
||||
private val listener = object : SimplePlayer.Listener {
|
||||
|
|
@ -55,13 +55,13 @@ object SimplePlayerModule {
|
|||
@Provides
|
||||
fun simplePlayerProvider(
|
||||
@ApplicationContext context: Context,
|
||||
): SimplePlayer = SimplePlayerImpl(ExoPlayer.Builder(context).build())
|
||||
): SimplePlayer = DefaultSimplePlayer(ExoPlayer.Builder(context).build())
|
||||
}
|
||||
|
||||
/**
|
||||
* Default implementation of [SimplePlayer] backed by a media3 [Player].
|
||||
*/
|
||||
class SimplePlayerImpl(
|
||||
class DefaultSimplePlayer(
|
||||
private val p: Player
|
||||
) : SimplePlayer {
|
||||
override fun addListener(listener: SimplePlayer.Listener) {
|
||||
|
|
|
|||
|
|
@ -19,7 +19,7 @@ package io.element.android.libraries.mediaplayer.impl
|
|||
import kotlinx.coroutines.test.runTest
|
||||
import org.junit.Test
|
||||
|
||||
class MediaPlayerImplTest {
|
||||
class DefaultMediaPlayerTest {
|
||||
@Test
|
||||
fun `default test`() = runTest {
|
||||
// TODO
|
||||
|
|
@ -29,7 +29,7 @@ import javax.inject.Inject
|
|||
|
||||
@SingleIn(AppScope::class)
|
||||
@ContributesBinding(AppScope::class, boundType = PushClientSecret::class)
|
||||
class PushClientSecretImpl @Inject constructor(
|
||||
class DefaultPushClientSecret @Inject constructor(
|
||||
private val pushClientSecretFactory: PushClientSecretFactory,
|
||||
private val pushClientSecretStore: PushClientSecretStore,
|
||||
private val sessionObserver: SessionObserver,
|
||||
|
|
@ -23,7 +23,7 @@ import java.util.UUID
|
|||
import javax.inject.Inject
|
||||
|
||||
@ContributesBinding(AppScope::class)
|
||||
class PushClientSecretFactoryImpl @Inject constructor() : PushClientSecretFactory {
|
||||
class DefaultPushClientSecretFactory @Inject constructor() : PushClientSecretFactory {
|
||||
override fun create(): String {
|
||||
return UUID.randomUUID().toString()
|
||||
}
|
||||
|
|
@ -28,12 +28,12 @@ private val A_USER_ID_1 = SessionId("@A_USER_ID_1:domain")
|
|||
|
||||
private const val A_UNKNOWN_SECRET = "A_UNKNOWN_SECRET"
|
||||
|
||||
internal class PushClientSecretImplTest {
|
||||
internal class DefaultPushClientSecretTest {
|
||||
@Test
|
||||
fun test() = runTest {
|
||||
val factory = FakePushClientSecretFactory()
|
||||
val store = InMemoryPushClientSecretStore()
|
||||
val sut = PushClientSecretImpl(factory, store, NoOpSessionObserver())
|
||||
val sut = DefaultPushClientSecret(factory, store, NoOpSessionObserver())
|
||||
|
||||
val secret0 = factory.getSecretForUser(0)
|
||||
val secret1 = factory.getSecretForUser(1)
|
||||
|
|
@ -51,7 +51,7 @@ import kotlin.time.TimeSource
|
|||
|
||||
@SingleIn(RoomScope::class)
|
||||
@ContributesBinding(RoomScope::class)
|
||||
class VoiceRecorderImpl @Inject constructor(
|
||||
class DefaultVoiceRecorder @Inject constructor(
|
||||
private val dispatchers: CoroutineDispatchers,
|
||||
private val timeSource: TimeSource,
|
||||
private val audioReaderFactory: AudioReader.Factory,
|
||||
|
|
@ -44,13 +44,13 @@ import kotlin.time.Duration.Companion.minutes
|
|||
import kotlin.time.Duration.Companion.seconds
|
||||
import kotlin.time.TestTimeSource
|
||||
|
||||
class VoiceRecorderImplTest {
|
||||
class DefaultVoiceRecorderTest {
|
||||
private val fakeFileSystem = FakeFileSystem()
|
||||
private val timeSource = TestTimeSource()
|
||||
|
||||
@Test
|
||||
fun `it emits the initial state`() = runTest {
|
||||
val voiceRecorder = createVoiceRecorder()
|
||||
val voiceRecorder = createDefaultVoiceRecorder()
|
||||
voiceRecorder.state.test {
|
||||
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
|
||||
}
|
||||
|
|
@ -58,7 +58,7 @@ class VoiceRecorderImplTest {
|
|||
|
||||
@Test
|
||||
fun `when recording, it emits the recording state`() = runTest {
|
||||
val voiceRecorder = createVoiceRecorder()
|
||||
val voiceRecorder = createDefaultVoiceRecorder()
|
||||
voiceRecorder.state.test {
|
||||
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
|
||||
|
||||
|
|
@ -73,7 +73,7 @@ class VoiceRecorderImplTest {
|
|||
|
||||
@Test
|
||||
fun `when elapsed time reaches 30 minutes, it stops recording`() = runTest {
|
||||
val voiceRecorder = createVoiceRecorder()
|
||||
val voiceRecorder = createDefaultVoiceRecorder()
|
||||
voiceRecorder.state.test {
|
||||
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
|
||||
|
||||
|
|
@ -96,7 +96,7 @@ class VoiceRecorderImplTest {
|
|||
|
||||
@Test
|
||||
fun `when stopped, it provides a file and duration`() = runTest {
|
||||
val voiceRecorder = createVoiceRecorder()
|
||||
val voiceRecorder = createDefaultVoiceRecorder()
|
||||
voiceRecorder.state.test {
|
||||
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
|
||||
|
||||
|
|
@ -119,7 +119,7 @@ class VoiceRecorderImplTest {
|
|||
|
||||
@Test
|
||||
fun `when cancelled, it deletes the file`() = runTest {
|
||||
val voiceRecorder = createVoiceRecorder()
|
||||
val voiceRecorder = createDefaultVoiceRecorder()
|
||||
voiceRecorder.state.test {
|
||||
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Idle)
|
||||
|
||||
|
|
@ -131,9 +131,9 @@ class VoiceRecorderImplTest {
|
|||
}
|
||||
}
|
||||
|
||||
private fun TestScope.createVoiceRecorder(): VoiceRecorderImpl {
|
||||
private fun TestScope.createDefaultVoiceRecorder(): DefaultVoiceRecorder {
|
||||
val fileConfig = VoiceRecorderModule.provideVoiceFileConfig()
|
||||
return VoiceRecorderImpl(
|
||||
return DefaultVoiceRecorder(
|
||||
dispatchers = testCoroutineDispatchers(),
|
||||
timeSource = timeSource,
|
||||
audioReaderFactory = FakeAudioReaderFactory(
|
||||
Loading…
Add table
Add a link
Reference in a new issue