Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Use @TestParameter instead of doing the work manually.

Browse source
This commit is contained in:
Benoit Marty 2026-04-15 08:32:26 +02:00
parent 98384dfbeb
commit 4985079b8c
2 changed files with 13 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

42
features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/onboarding/OnboardingViewTest.kt
View file

@ -13,7 +13,8 @@ import androidx.compose.ui.test.junit4.AndroidComposeTestRule
import androidx.compose.ui.test.junit4.createAndroidComposeRule import androidx.compose.ui.test.junit4.createAndroidComposeRule
import androidx.compose.ui.test.onNodeWithText import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick import androidx.compose.ui.test.performClick
import androidx.test.ext.junit.runners.AndroidJUnit4 import com.google.testing.junit.testparameterinjector.KotlinTestParameters.namedTestValues
import com.google.testing.junit.testparameterinjector.TestParameter
import io.element.android.features.login.impl.R import io.element.android.features.login.impl.R
import io.element.android.features.login.impl.login.LoginMode import io.element.android.features.login.impl.login.LoginMode
import io.element.android.libraries.architecture.AsyncData import io.element.android.libraries.architecture.AsyncData
@ -31,8 +32,9 @@ import org.junit.Rule
import org.junit.Test import org.junit.Test
import org.junit.rules.TestRule import org.junit.rules.TestRule
import org.junit.runner.RunWith import org.junit.runner.RunWith
import org.robolectric.RobolectricTestParameterInjector
@RunWith(AndroidJUnit4::class) @RunWith(RobolectricTestParameterInjector::class)
class OnboardingViewTest { class OnboardingViewTest {
@get:Rule @get:Rule
val rule = createAndroidComposeRule<ComponentActivity>() val rule = createAndroidComposeRule<ComponentActivity>()
@ -83,21 +85,11 @@ class OnboardingViewTest {
} }
@Test @Test
fun `when can login with QR code - clicking on sign in manually calls the expected callback - can search account provider`() { fun `when can login with QR code - clicking on sign in manually calls the expected callback`(
`when can login with QR code - clicking on sign in manually calls the expected callback`( @TestParameter mustChooseAccountProvider: Boolean = namedTestValues(
mustChooseAccountProvider = false, "can search account provider" to false,
"cannot search account provider" to true,
) )
}
@Test
fun `when can login with QR code - clicking on sign in manually calls the expected callback - cannot search account provider`() {
`when can login with QR code - clicking on sign in manually calls the expected callback`(
mustChooseAccountProvider = true,
)
}
private fun `when can login with QR code - clicking on sign in manually calls the expected callback`(
mustChooseAccountProvider: Boolean,
) { ) {
val eventSink = EventsRecorder<OnBoardingEvents>(expectEvents = false) val eventSink = EventsRecorder<OnBoardingEvents>(expectEvents = false)
ensureCalledOnceWithParam(mustChooseAccountProvider) { callback -> ensureCalledOnceWithParam(mustChooseAccountProvider) { callback ->
@ -114,21 +106,11 @@ class OnboardingViewTest {
} }
@Test @Test
fun `when cannot login with QR code or create account - clicking on continue calls the sign in callback - can search account provider`() { fun `when cannot login with QR code or create account - clicking on continue calls the sign in callback`(
`when cannot login with QR code or create account - clicking on continue calls the sign in callback`( @TestParameter mustChooseAccountProvider: Boolean = namedTestValues(
mustChooseAccountProvider = false, "can search account provider" to false,
"cannot search account provider" to true,
) )
}
@Test
fun `when cannot login with QR code or create account - clicking on continue calls the sign in callback - cannot search account provider`() {
`when cannot login with QR code or create account - clicking on continue calls the sign in callback`(
mustChooseAccountProvider = true,
)
}
private fun `when cannot login with QR code or create account - clicking on continue calls the sign in callback`(
mustChooseAccountProvider: Boolean,
) { ) {
val eventSink = EventsRecorder<OnBoardingEvents>(expectEvents = false) val eventSink = EventsRecorder<OnBoardingEvents>(expectEvents = false)
ensureCalledOnceWithParam(mustChooseAccountProvider) { callback -> ensureCalledOnceWithParam(mustChooseAccountProvider) { callback ->

1
plugins/src/main/kotlin/extension/DependencyHandleScope.kt
View file

@ -49,6 +49,7 @@ fun DependencyHandlerScope.testCommonDependencies(
testImplementation(libs.test.arch.core) testImplementation(libs.test.arch.core)
testImplementation(libs.test.junit) testImplementation(libs.test.junit)
testImplementation(libs.test.mockk) testImplementation(libs.test.mockk)
testImplementation(libs.test.parameter.injector)
testImplementation(libs.test.robolectric) testImplementation(libs.test.robolectric)
testImplementation(libs.test.truth) testImplementation(libs.test.truth)
testImplementation(libs.test.turbine) testImplementation(libs.test.turbine)