Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix lint issues

Browse source
This commit is contained in:
Jorge Martín 2023-08-17 15:31:14 +02:00 • committed by yostyle
parent a210945bb1
commit 4b0f9213d3
6 changed files with 15 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/RoomNotificationSettingsOption.kt
View file

@ -79,7 +79,7 @@ fun RoomNotificationSettingsOption(
@DayNightPreviews
@Composable
fun RoomPrivacyOptionLightPreview() = ElementPreview { ContentToPreview() }
internal fun RoomPrivacyOptionLightPreview() = ElementPreview { ContentToPreview() }
@Composable
private fun ContentToPreview() {

10
features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/RoomNotificationSettingsView.kt
View file

@ -54,6 +54,7 @@ fun RoomNotificationSettingsView(
onBackPressed: () -> Unit = {},
) {
Scaffold(
modifier = modifier,
topBar = {
RoomNotificationSettingsTopBar(
onBackPressed = { onBackPressed() }
@ -61,7 +62,7 @@ fun RoomNotificationSettingsView(
}
) { padding ->
Column(
modifier = modifier
modifier = Modifier
.fillMaxWidth()
.padding(padding)
.consumeWindowInsets(padding),
@ -94,7 +95,6 @@ fun RoomNotificationSettingsView(
if (state.roomNotificationSettings != null) {
RoomNotificationSettingsOptions(
modifier = modifier,
selected = state.roomNotificationSettings.mode,
enabled = !state.roomNotificationSettings.isDefault,
onOptionSelected = {
@ -128,8 +128,8 @@ fun RoomNotificationSettingsTopBar(
@Composable
fun RoomNotificationSettingsOptions(
selected: RoomNotificationMode?,
modifier: Modifier = Modifier,
enabled: Boolean,
modifier: Modifier = Modifier,
onOptionSelected: (RoomNotificationSettingsItem) -> Unit = {},
) {
val items = roomNotificationSettingsItems()
@ -147,12 +147,12 @@ fun RoomNotificationSettingsOptions(
@Preview
@Composable
fun RoomNotificationSettingsLightPreview(@PreviewParameter(RoomNotificationSettingsStateProvider::class) state: RoomNotificationSettingsState) =
internal fun RoomNotificationSettingsLightPreview(@PreviewParameter(RoomNotificationSettingsStateProvider::class) state: RoomNotificationSettingsState) =
ElementPreviewLight { ContentToPreview(state) }
@Preview
@Composable
fun RoomNotificationSettingsDarkPreview(@PreviewParameter(RoomNotificationSettingsStateProvider::class) state: RoomNotificationSettingsState) =
internal fun RoomNotificationSettingsDarkPreview(@PreviewParameter(RoomNotificationSettingsStateProvider::class) state: RoomNotificationSettingsState) =
ElementPreviewDark { ContentToPreview(state) }
@Composable

6
features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/RoomDetailsPresenterTests.kt
View file

@ -51,7 +51,11 @@ import org.junit.Test
@ExperimentalCoroutinesApi
class RoomDetailsPresenterTests {
private fun aRoomDetailsPresenter(room: MatrixRoom, leaveRoomPresenter: LeaveRoomPresenter = LeaveRoomPresenterFake(), dispatchers: CoroutineDispatchers): RoomDetailsPresenter {
private fun aRoomDetailsPresenter(
room: MatrixRoom,
leaveRoomPresenter: LeaveRoomPresenter = LeaveRoomPresenterFake(),
dispatchers: CoroutineDispatchers
): RoomDetailsPresenter {
val matrixClient = FakeMatrixClient()
val roomMemberDetailsPresenterFactory = object : RoomMemberDetailsPresenter.Factory {
override fun create(roomMemberId: UserId): RoomMemberDetailsPresenter {