Rename method.

This commit is contained in:
Benoit Marty 2025-08-23 16:19:56 +02:00 committed by Benoit Marty
parent 2b42271615
commit 4daf57ab2d
4 changed files with 7 additions and 7 deletions

View file

@ -33,7 +33,7 @@ class DefaultIntentProvider @Inject constructor(
): Intent { ): Intent {
return Intent(context, MainActivity::class.java).apply { return Intent(context, MainActivity::class.java).apply {
action = Intent.ACTION_VIEW action = Intent.ACTION_VIEW
data = deepLinkCreator.room(sessionId, roomId, threadId).toUri() data = deepLinkCreator.create(sessionId, roomId, threadId).toUri()
} }
} }
} }

View file

@ -12,5 +12,5 @@ import io.element.android.libraries.matrix.api.core.SessionId
import io.element.android.libraries.matrix.api.core.ThreadId import io.element.android.libraries.matrix.api.core.ThreadId
fun interface DeepLinkCreator { fun interface DeepLinkCreator {
fun room(sessionId: SessionId, roomId: RoomId?, threadId: ThreadId?): String fun create(sessionId: SessionId, roomId: RoomId?, threadId: ThreadId?): String
} }

View file

@ -17,7 +17,7 @@ import javax.inject.Inject
@ContributesBinding(AppScope::class) @ContributesBinding(AppScope::class)
class DefaultDeepLinkCreator @Inject constructor() : DeepLinkCreator { class DefaultDeepLinkCreator @Inject constructor() : DeepLinkCreator {
override fun room(sessionId: SessionId, roomId: RoomId?, threadId: ThreadId?): String { override fun create(sessionId: SessionId, roomId: RoomId?, threadId: ThreadId?): String {
return buildString { return buildString {
append("$SCHEME://$HOST/") append("$SCHEME://$HOST/")
append(sessionId.value) append(sessionId.value)

View file

@ -15,13 +15,13 @@ import org.junit.Test
class DefaultDeepLinkCreatorTest { class DefaultDeepLinkCreatorTest {
@Test @Test
fun room() { fun create() {
val sut = DefaultDeepLinkCreator() val sut = DefaultDeepLinkCreator()
assertThat(sut.room(A_SESSION_ID, null, null)) assertThat(sut.create(A_SESSION_ID, null, null))
.isEqualTo("elementx://open/@alice:server.org") .isEqualTo("elementx://open/@alice:server.org")
assertThat(sut.room(A_SESSION_ID, A_ROOM_ID, null)) assertThat(sut.create(A_SESSION_ID, A_ROOM_ID, null))
.isEqualTo("elementx://open/@alice:server.org/!aRoomId:domain") .isEqualTo("elementx://open/@alice:server.org/!aRoomId:domain")
assertThat(sut.room(A_SESSION_ID, A_ROOM_ID, A_THREAD_ID)) assertThat(sut.create(A_SESSION_ID, A_ROOM_ID, A_THREAD_ID))
.isEqualTo("elementx://open/@alice:server.org/!aRoomId:domain/\$aThreadId") .isEqualTo("elementx://open/@alice:server.org/!aRoomId:domain/\$aThreadId")
} }
} }