Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Use MimeTypes object instead of hard-coded strings.

Browse source
This commit is contained in:
Benoit Marty 2023-11-27 21:55:39 +01:00 • committed by Benoit Marty
parent 04be1f0385
commit 4f32299280
14 changed files with 37 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

3
libraries/voicerecorder/impl/src/main/kotlin/io/element/android/libraries/voicerecorder/impl/di/VoiceRecorderModule.kt
View file

@ -21,6 +21,7 @@ import android.media.MediaRecorder
import com.squareup.anvil.annotations.ContributesTo
import dagger.Module
import dagger.Provides
import io.element.android.libraries.core.mimetype.MimeTypes
import io.element.android.libraries.di.RoomScope
import io.element.android.libraries.voicerecorder.impl.audio.AudioConfig
import io.element.android.libraries.voicerecorder.impl.audio.SampleRate
@ -50,7 +51,7 @@ object VoiceRecorderModule {
VoiceFileConfig(
cacheSubdir = "voice_recordings",
fileExt = "ogg",
mimeType = "audio/ogg",
mimeType = MimeTypes.Ogg,
)
@Provides

5
libraries/voicerecorder/impl/src/test/kotlin/io/element/android/libraries/voicerecorder/impl/VoiceRecorderImplTest.kt
View file

@ -21,6 +21,7 @@ import android.media.MediaRecorder
import app.cash.turbine.test
import com.google.common.truth.Truth.assertThat
import io.element.android.appconfig.VoiceMessageConfig
import io.element.android.libraries.core.mimetype.MimeTypes
import io.element.android.libraries.voicerecorder.api.VoiceRecorderState
import io.element.android.libraries.voicerecorder.impl.audio.Audio
import io.element.android.libraries.voicerecorder.impl.audio.AudioConfig
@ -85,7 +86,7 @@ class VoiceRecorderImplTest {
assertThat(awaitItem()).isEqualTo(
VoiceRecorderState.Finished(
file = File(FILE_PATH),
mimeType = "audio/ogg",
mimeType = MimeTypes.Ogg,
waveform = List(100) { 1f },
duration = VoiceMessageConfig.maxVoiceMessageDuration,
)
@ -107,7 +108,7 @@ class VoiceRecorderImplTest {
assertThat(awaitItem()).isEqualTo(
VoiceRecorderState.Finished(
file = File(FILE_PATH),
mimeType = "audio/ogg",
mimeType = MimeTypes.Ogg,
waveform = List(100) { 1f },
duration = 5.seconds,
)