Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Add missing test on CrashDetectionPresenter

Browse source
This commit is contained in:
Benoit Marty 2025-08-11 11:10:32 +02:00
parent 78bd174d10
commit 50809d2adb
2 changed files with 35 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/crash/FakeCrashDataStore.kt
View file

@ -21,6 +21,7 @@ class FakeCrashDataStore(
override fun setCrashData(crashData: String) { override fun setCrashData(crashData: String) {
crashDataFlow.value = crashData crashDataFlow.value = crashData
appHasCrashedFlow.value = true
} }
override suspend fun resetAppHasCrashed() { override suspend fun resetAppHasCrashed() {

37
features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/crash/ui/CrashDetectionPresenterTest.kt
View file

@ -18,6 +18,8 @@ import io.element.android.features.rageshake.impl.crash.FakeCrashDataStore
import io.element.android.libraries.core.meta.BuildMeta import io.element.android.libraries.core.meta.BuildMeta
import io.element.android.libraries.matrix.test.core.aBuildMeta import io.element.android.libraries.matrix.test.core.aBuildMeta
import io.element.android.tests.testutils.WarmUpRule import io.element.android.tests.testutils.WarmUpRule
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.flowOf import kotlinx.coroutines.flow.flowOf
import kotlinx.coroutines.test.runTest import kotlinx.coroutines.test.runTest
import org.junit.Rule import org.junit.Rule
@ -56,7 +58,7 @@ class CrashDetectionPresenterTest {
fun `present - initial state crash is ignored if the feature is not available`() = runTest { fun `present - initial state crash is ignored if the feature is not available`() = runTest {
val presenter = createPresenter( val presenter = createPresenter(
FakeCrashDataStore(appHasCrashed = true), FakeCrashDataStore(appHasCrashed = true),
isFeatureAvailable = false, isFeatureAvailableFlow = flowOf(false),
) )
moleculeFlow(RecompositionMode.Immediate) { moleculeFlow(RecompositionMode.Immediate) {
presenter.present() presenter.present()
@ -98,13 +100,42 @@ class CrashDetectionPresenterTest {
} }
} }
@Test
fun `present - crashDetected is false if the feature is not available`() = runTest {
val isFeatureAvailableFlow = MutableStateFlow(false)
val crashDataStore = FakeCrashDataStore(appHasCrashed = false)
val presenter = createPresenter(
crashDataStore = crashDataStore,
isFeatureAvailableFlow = isFeatureAvailableFlow,
)
moleculeFlow(RecompositionMode.Immediate) {
presenter.present()
}.test {
val initialState = awaitItem()
assertThat(initialState.crashDetected).isFalse()
crashDataStore.setCrashData("Some crash data")
// No new state
crashDataStore.resetAppHasCrashed()
// No new state
isFeatureAvailableFlow.value = true
crashDataStore.setCrashData("Some crash data")
assertThat(awaitItem().crashDetected).isTrue()
crashDataStore.resetAppHasCrashed()
assertThat(awaitItem().crashDetected).isFalse()
crashDataStore.setCrashData("Some crash data")
assertThat(awaitItem().crashDetected).isTrue()
isFeatureAvailableFlow.value = false
assertThat(awaitItem().crashDetected).isFalse()
}
}
private fun createPresenter( private fun createPresenter(
crashDataStore: FakeCrashDataStore = FakeCrashDataStore(), crashDataStore: FakeCrashDataStore = FakeCrashDataStore(),
buildMeta: BuildMeta = aBuildMeta(), buildMeta: BuildMeta = aBuildMeta(),
isFeatureAvailable: Boolean = true, isFeatureAvailableFlow: Flow<Boolean> = flowOf(true),
) = DefaultCrashDetectionPresenter( ) = DefaultCrashDetectionPresenter(
buildMeta = buildMeta, buildMeta = buildMeta,
crashDataStore = crashDataStore, crashDataStore = crashDataStore,
rageshakeFeatureAvailability = { flowOf(isFeatureAvailable) }, rageshakeFeatureAvailability = { isFeatureAvailableFlow },
) )
} }