Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Rename UserPushStoreFactory.create to UserPushStoreFactory.getOrCreate for code clarity.

Browse source
This commit is contained in:
Benoit Marty 2024-04-02 16:23:57 +02:00 • committed by Benoit Marty
parent e18e5f1cc5
commit 52c039d676
11 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
libraries/pushstore/impl/src/androidTest/kotlin/io/element/android/libraries/pushstore/impl/DefaultUserPushStoreFactoryTest.kt
View file

@ -40,11 +40,11 @@ class DefaultUserPushStoreFactoryTest {
val userPushStoreFactory = DefaultUserPushStoreFactory(context, NoOpSessionObserver())
var userPushStore1: UserPushStore? = null
val thread1 = thread {
userPushStore1 = userPushStoreFactory.create(sessionId)
userPushStore1 = userPushStoreFactory.getOrCreate(sessionId)
}
var userPushStore2: UserPushStore? = null
val thread2 = thread {
userPushStore2 = userPushStoreFactory.create(sessionId)
userPushStore2 = userPushStoreFactory.getOrCreate(sessionId)
}
thread1.join()
thread2.join()

4
libraries/pushstore/impl/src/main/kotlin/io/element/android/libraries/pushstore/impl/DefaultUserPushStoreFactory.kt
View file

@ -41,7 +41,7 @@ class DefaultUserPushStoreFactory @Inject constructor(
// We can have only one class accessing a single data store, so keep a cache of them.
private val cache = ConcurrentHashMap<SessionId, UserPushStore>()
override fun create(userId: SessionId): UserPushStore {
override fun getOrCreate(userId: SessionId): UserPushStore {
return cache.getOrPut(userId) {
UserPushStoreDataStore(
context = context,
@ -60,6 +60,6 @@ class DefaultUserPushStoreFactory @Inject constructor(
override suspend fun onSessionDeleted(userId: String) {
// Delete the store
create(SessionId(userId)).reset()
getOrCreate(SessionId(userId)).reset()
}
}