Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Do not render filename of voice message.

Browse source
This commit is contained in:
Benoit Marty 2024-11-04 16:05:23 +01:00 • committed by Benoit Marty
parent 7bcbd2181a
commit 533252a44e
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
libraries/eventformatter/impl/src/main/kotlin/io/element/android/libraries/eventformatter/impl/DefaultPinnedMessagesBannerFormatter.kt
View file

@ -95,7 +95,9 @@ class DefaultPinnedMessagesBannerFormatter @Inject constructor(
messageType.bestDescription.prefixWith(CommonStrings.common_audio) messageType.bestDescription.prefixWith(CommonStrings.common_audio)
} }
is VoiceMessageType -> { is VoiceMessageType -> {
messageType.bestDescription.prefixWith(CommonStrings.common_voice_message) // In this case, do not use bestDescription, because the filename is useless, only use the caption if available.
messageType.caption?.prefixWith(sp.getString(CommonStrings.common_voice_message))
?: sp.getString(CommonStrings.common_voice_message)
} }
is OtherMessageType -> { is OtherMessageType -> {
messageType.body messageType.body

4
libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultPinnedMessagesBannerFormatterTest.kt
View file

@ -159,11 +159,11 @@ class DefaultPinnedMessagesBannerFormatterTest {
val expectedResult = when (type) { val expectedResult = when (type) {
is VideoMessageType, is VideoMessageType,
is AudioMessageType, is AudioMessageType,
is VoiceMessageType,
is ImageMessageType, is ImageMessageType,
is StickerMessageType, is StickerMessageType,
is FileMessageType, is FileMessageType,
is LocationMessageType -> AnnotatedString::class.java is LocationMessageType -> AnnotatedString::class.java
is VoiceMessageType,
is EmoteMessageType, is EmoteMessageType,
is TextMessageType, is TextMessageType,
is NoticeMessageType, is NoticeMessageType,
@ -176,7 +176,7 @@ class DefaultPinnedMessagesBannerFormatterTest {
val expectedResult = when (type) { val expectedResult = when (type) {
is VideoMessageType -> "Video: Shared body" is VideoMessageType -> "Video: Shared body"
is AudioMessageType -> "Audio: Shared body" is AudioMessageType -> "Audio: Shared body"
is VoiceMessageType -> "Voice message: Shared body" is VoiceMessageType -> "Voice message"
is ImageMessageType -> "Image: Shared body" is ImageMessageType -> "Image: Shared body"
is StickerMessageType -> "Sticker: Shared body" is StickerMessageType -> "Sticker: Shared body"
is FileMessageType -> "File: Shared body" is FileMessageType -> "File: Shared body"