We do not require Sign-off anymore, but use CLA instead.

This commit is contained in:
Benoit Marty 2024-12-13 16:10:21 +01:00
parent 18b97a4a56
commit 538936df9c
4 changed files with 1 additions and 69 deletions

View file

@ -24,7 +24,6 @@ Here are the checks that Danger does so far:
- Big PR got a warning to recommend to split
- PR contains a correct title and a label to categorize the release note
- PR does not modify frozen classes
- PR contains a Sign-Off, with exception for Element employee contributors
- PR with change on layout should include screenshot in the description (TODO Not supported yet!)
- PR which adds png file warn about the usage of vector drawables
- non draft PR should have a reviewer

View file

@ -173,7 +173,7 @@ But comment in PR from the community are always appreciated!
4. Fork consideration. Will configuration of forks be easy? Some documentation may help in some cases.
5. We are building long term products. "Quick and dirty" code must be avoided.
6. The PR includes new tests for the added code, updated test for the existing code
7. All PRs from external contributors **MUST** include a sign-off. It's in the checklist, and sometimes it's checked by the submitter, but there is actually no sign-off. In this case, ask nicely for a sign-off and request changes (do not approve the PR, even if everything else is fine).
7. All commit authors must have signed the CLA. Please open https://cla-assistant.io/element-hq/element-x-android to agree to the CLA.
### Rules