We do not require Sign-off anymore, but use CLA instead.
This commit is contained in:
parent
18b97a4a56
commit
538936df9c
4 changed files with 1 additions and 69 deletions
|
|
@ -48,72 +48,6 @@ frozenClasses.forEach(frozen => {
|
|||
}
|
||||
)
|
||||
|
||||
// Check for a sign-off
|
||||
const signOff = "Signed-off-by:"
|
||||
|
||||
// Please add new names following the alphabetical order.
|
||||
const allowList = [
|
||||
"aringenbach",
|
||||
"BillCarsonFr",
|
||||
"bmarty",
|
||||
"csmith",
|
||||
"dependabot[bot]",
|
||||
"Florian14",
|
||||
"ganfra",
|
||||
"github-actions[bot]",
|
||||
"jmartinesp",
|
||||
"jonnyandrew",
|
||||
"julioromano",
|
||||
"kittykat",
|
||||
"langleyd",
|
||||
"MadLittleMods",
|
||||
"manuroe",
|
||||
"renovate[bot]",
|
||||
"stefanceriu",
|
||||
"yostyle",
|
||||
]
|
||||
|
||||
function signoff_needed(reason) {
|
||||
message("Sign-off required, " + reason)
|
||||
const hasPRBodySignOff = pr.body.includes(signOff)
|
||||
const hasCommitSignOff = danger.git.commits.every(commit => commit.message.includes(signOff))
|
||||
if (!hasPRBodySignOff && !hasCommitSignOff) {
|
||||
fail("Please add a sign-off to either the PR description or to the commits themselves. See instructions [here](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off).")
|
||||
}
|
||||
}
|
||||
|
||||
function signoff_unneeded(reason) {
|
||||
message("Sign-off not required, " + reason)
|
||||
}
|
||||
|
||||
// Somewhat awkward phrasing, dangerfile is not in an async context.
|
||||
if (allowList.includes(user)) {
|
||||
signoff_unneeded("allow-list")
|
||||
} else {
|
||||
// github.api.rest.orgs.checkMembershipForUser({
|
||||
// org: "element-hq",
|
||||
// username: user,
|
||||
// }).then((result) => {
|
||||
github.api.rest.teams.getMembershipForUserInOrg({
|
||||
org: "element-hq",
|
||||
team_slug: "vector-core",
|
||||
username: user,
|
||||
}).then((result) => {
|
||||
if (result.status == 204 || result.status == 200) {
|
||||
signoff_unneeded("team-member")
|
||||
}
|
||||
else {
|
||||
signoff_needed("not-team-member")
|
||||
}
|
||||
}).catch((error) => {
|
||||
if (error.response.status == 404) {
|
||||
signoff_needed("not-team-member");
|
||||
} else {
|
||||
console.log(error); signoff_needed("error")
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
const previewAnnotations = [
|
||||
'androidx.compose.ui.tooling.preview.Preview',
|
||||
'io.element.android.libraries.designsystem.preview.PreviewWithLargeHeight',
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue