From 53adb456ba63f77fdd1ee6f4accfd5c6d8dec280 Mon Sep 17 00:00:00 2001 From: Florian Renaud Date: Fri, 12 May 2023 13:30:06 +0200 Subject: [PATCH] Test cleanup --- .../userlist/impl/DefaultUserListPresenterTests.kt | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/features/userlist/impl/src/test/kotlin/io/element/android/features/userlist/impl/DefaultUserListPresenterTests.kt b/features/userlist/impl/src/test/kotlin/io/element/android/features/userlist/impl/DefaultUserListPresenterTests.kt index ae2f709608..b13881dc5b 100644 --- a/features/userlist/impl/src/test/kotlin/io/element/android/features/userlist/impl/DefaultUserListPresenterTests.kt +++ b/features/userlist/impl/src/test/kotlin/io/element/android/features/userlist/impl/DefaultUserListPresenterTests.kt @@ -16,7 +16,6 @@ package io.element.android.features.userlist.impl -import androidx.compose.foundation.lazy.LazyListState import app.cash.molecule.RecompositionClock import app.cash.molecule.moleculeFlow import app.cash.turbine.test @@ -30,8 +29,6 @@ import io.element.android.features.userlist.test.FakeUserListDataSource import io.element.android.libraries.matrix.api.core.UserId import io.element.android.libraries.matrix.api.user.MatrixUser import io.element.android.libraries.matrix.ui.components.aMatrixUser -import io.mockk.coJustRun -import io.mockk.mockkConstructor import kotlinx.collections.immutable.persistentListOf import kotlinx.coroutines.test.runTest import org.junit.Test @@ -134,9 +131,6 @@ class DefaultUserListPresenterTests { @Test fun `present - select a user`() = runTest { - mockkConstructor(LazyListState::class) - coJustRun { anyConstructed().scrollToItem(index = any()) } - val presenter = DefaultUserListPresenter( UserListPresenterArgs(selectionMode = SelectionMode.Single), userListDataSource, @@ -156,16 +150,15 @@ class DefaultUserListPresenterTests { assertThat(awaitItem().selectedUsers).containsExactly(userA) initialState.eventSink(UserListEvents.AddToSelection(userB)) - // the last added user should be presented first - assertThat(awaitItem().selectedUsers).containsExactly(userB, userA) + assertThat(awaitItem().selectedUsers).containsExactly(userA, userB) initialState.eventSink(UserListEvents.AddToSelection(userABis)) initialState.eventSink(UserListEvents.AddToSelection(userC)) // duplicated users should be ignored - assertThat(awaitItem().selectedUsers).containsExactly(userC, userB, userA) + assertThat(awaitItem().selectedUsers).containsExactly(userA, userB, userC) initialState.eventSink(UserListEvents.RemoveFromSelection(userB)) - assertThat(awaitItem().selectedUsers).containsExactly(userC, userA) + assertThat(awaitItem().selectedUsers).containsExactly(userA, userC) initialState.eventSink(UserListEvents.RemoveFromSelection(userA)) assertThat(awaitItem().selectedUsers).containsExactly(userC) initialState.eventSink(UserListEvents.RemoveFromSelection(userC))