Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix lint UnnecessaryComposedModifier and make it an error

Browse source
This commit is contained in:
Benoit Marty 2023-09-28 16:55:21 +02:00
parent 4a63847245
commit 5964591a19
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/modifiers/Blur.kt
View file

@ -21,7 +21,6 @@ import android.os.Build
import androidx.annotation.ChecksSdkIntAtLeast import androidx.annotation.ChecksSdkIntAtLeast
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.composed
import androidx.compose.ui.draw.BlurredEdgeTreatment import androidx.compose.ui.draw.BlurredEdgeTreatment
import androidx.compose.ui.draw.blur import androidx.compose.ui.draw.blur
import androidx.compose.ui.draw.drawBehind import androidx.compose.ui.draw.drawBehind
@ -94,8 +93,8 @@ fun Modifier.blurredShapeShadow(
fun Modifier.blurCompat( fun Modifier.blurCompat(
radius: Dp, radius: Dp,
edgeTreatment: BlurredEdgeTreatment = BlurredEdgeTreatment.Rectangle edgeTreatment: BlurredEdgeTreatment = BlurredEdgeTreatment.Rectangle
): Modifier = composed { ): Modifier {
when { return when {
radius.value == 0f -> this radius.value == 0f -> this
canUseBlur() -> blur(radius, edgeTreatment) canUseBlur() -> blur(radius, edgeTreatment)
else -> this // Added in case we find a way to make this work on older devices else -> this // Added in case we find a way to make this work on older devices

3
tools/lint/lint.xml
View file

@ -124,4 +124,7 @@
<!-- DI --> <!-- DI -->
<!-- issue id="JvmStaticProvidesInObjectDetector" severity="error" /--> <!-- issue id="JvmStaticProvidesInObjectDetector" severity="error" /-->
<!-- Compose -->
<issue id="UnnecessaryComposedModifier" severity="error" />
</lint> </lint>