Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Ensure that room / space avatar always have a contentDescription.

Browse source
This commit is contained in:
Benoit Marty 2026-01-02 16:23:15 +01:00
parent 78ad8056a1
commit 5b6dfca5d3
4 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsView.kt
View file

@ -404,7 +404,7 @@ private fun RoomHeaderSection(
}.toImmutableList(), }.toImmutableList(),
isTombstoned = isTombstoned, isTombstoned = isTombstoned,
), ),
contentDescription = avatarUrl?.let { stringResource(CommonStrings.a11y_room_avatar) }, contentDescription = stringResource(CommonStrings.a11y_room_avatar),
modifier = Modifier modifier = Modifier
.clickable( .clickable(
enabled = avatarUrl != null, enabled = avatarUrl != null,

2
features/space/impl/src/main/kotlin/io/element/android/features/space/impl/settings/SpaceSettingsView.kt
View file

@ -115,7 +115,7 @@ private fun SpaceInfoSection(
Avatar( Avatar(
avatarData = AvatarData(roomId.value, name, avatarUrl, AvatarSize.SpaceListItem), avatarData = AvatarData(roomId.value, name, avatarUrl, AvatarSize.SpaceListItem),
avatarType = AvatarType.Space(), avatarType = AvatarType.Space(),
contentDescription = avatarUrl?.let { stringResource(CommonStrings.a11y_avatar) }, contentDescription = stringResource(CommonStrings.a11y_avatar),
) )
Spacer(Modifier.width(16.dp)) Spacer(Modifier.width(16.dp))
Column { Column {

2
features/userprofile/shared/src/main/kotlin/io/element/android/features/userprofile/shared/UserProfileHeaderSection.kt
View file

@ -66,7 +66,7 @@ fun UserProfileHeaderSection(
Avatar( Avatar(
avatarData = AvatarData(userId.value, userName, avatarUrl, AvatarSize.UserHeader), avatarData = AvatarData(userId.value, userName, avatarUrl, AvatarSize.UserHeader),
avatarType = AvatarType.User, avatarType = AvatarType.User,
contentDescription = avatarUrl?.let { stringResource(CommonStrings.a11y_user_avatar) }, contentDescription = stringResource(CommonStrings.a11y_user_avatar),
modifier = Modifier modifier = Modifier
.clip(CircleShape) .clip(CircleShape)
.clickable( .clickable(

4
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/avatar/DmAvatars.kt
View file

@ -59,7 +59,7 @@ fun DmAvatars(
Avatar( Avatar(
avatarData = userAvatarData, avatarData = userAvatarData,
avatarType = AvatarType.User, avatarType = AvatarType.User,
contentDescription = userAvatarData.url?.let { stringResource(CommonStrings.a11y_your_avatar) }, contentDescription = stringResource(CommonStrings.a11y_your_avatar),
modifier = Modifier modifier = Modifier
.align(Alignment.BottomStart) .align(Alignment.BottomStart)
.graphicsLayer { .graphicsLayer {
@ -94,7 +94,7 @@ fun DmAvatars(
Avatar( Avatar(
avatarData = otherUserAvatarData, avatarData = otherUserAvatarData,
avatarType = AvatarType.User, avatarType = AvatarType.User,
contentDescription = otherUserAvatarData.url?.let { stringResource(CommonStrings.a11y_other_user_avatar) }, contentDescription = stringResource(CommonStrings.a11y_other_user_avatar),
modifier = Modifier modifier = Modifier
.align(Alignment.TopEnd) .align(Alignment.TopEnd)
.clip(CircleShape) .clip(CircleShape)