Apply suggestion:

- Added `MediaSource.safeUrl` property replacing `withCleanUrl` method.
- Made `url` private so it can't be used externally.
- Reverted code in `CoilMediaFetcher`
- Also add tests

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/media/MediaSource.kt

@@ -9,7 +9,7 @@
 package io.element.android.libraries.matrix.api.media
 
 import android.os.Parcelable
-import androidx.core.net.toUri
+import kotlinx.parcelize.IgnoredOnParcel
 import kotlinx.parcelize.Parcelize
 
 @Parcelize
@@ -17,31 +17,20 @@ data class MediaSource(
     /**
      * Url of the media.
      */
-    val url: String,
+    private val url: String,
     /**
      * This is used to hold data for encrypted media.
      */
     val json: String? = null,
-) : Parcelable
-
-/**
- * Returns a new [MediaSource] with a valid URL.
- */
-fun MediaSource.withCleanUrl(): MediaSource {
-    val uri = this.url.toUri()
-    if (uri.scheme != "mxc") return this
-
-    // We've seen some MXC urls in the wild having some `mxc://foo/bar#auto` fragment suffix, which is invalid
-    val cleanedUrl = buildString {
-        append(uri.scheme)
-        if (!this.endsWith("://")) {
-            append("://")
-        }
-        append(uri.host)
-        if (uri.path != null) {
-            append(uri.path)
-        }
+) : Parcelable {
+    /**
+     * A URL with invalid parts (like `#fragment`, if it's an MXC url) removed.
+     */
+    @IgnoredOnParcel
+    val safeUrl = if (url.startsWith("mxc")) {
+        // We've seen some MXC urls in the wild having some `mxc://foo/bar#auto` fragment suffix, which is invalid
+        url.substringBefore("#")
+    } else {
+        url
     }
-
-    return this.copy(url = cleanedUrl)
 }