Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix bitrate value used for video transcoding (#5183)

Browse source 
* Fix bitrate value used for video transcoding:

It should be 1000 times what it is now. The video size estimation was wrong since the retrieved duration value was in milliseconds, not seconds.

* Use `Duration` as the result type for `getDuration`
This commit is contained in:
Jorge Martin Espinosa 2025-08-18 23:12:11 +02:00 • committed by GitHub
parent aac9642159
commit 5feb7a99a9
5 changed files with 15 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
features/messages/test/src/main/kotlin/io/element/android/features/messages/test/attachments/video/FakeVideoMetadataExtractor.kt
View file

@ -10,14 +10,16 @@ package io.element.android.features.messages.test.attachments.video
import android.net.Uri
import android.util.Size
import io.element.android.features.messages.impl.attachments.video.VideoMetadataExtractor
import kotlin.time.Duration
import kotlin.time.Duration.Companion.milliseconds
class FakeVideoMetadataExtractor(
private val sizeResult: Result<Size> = Result.success(Size(1, 1)),
private val duration: Result<Long> = Result.success(1L),
private val duration: Result<Duration> = Result.success(1.milliseconds),
) : VideoMetadataExtractor {
override fun getSize(): Result<Size> = sizeResult
override fun getDuration(): Result<Long> = duration
override fun getDuration(): Result<Duration> = duration
override fun close() = Unit
}