Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 11 Projects Releases Packages Wiki Activity Actions

Add Konsist test to use isFalse() instead of isEqualTo(false), and fix existing issues.

Browse source
This commit is contained in:
Benoit Marty 2023-12-04 15:21:25 +01:00
parent 45883975c4
commit 65924eac6b
9 changed files with 85 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

18
features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/edit/RoomDetailsEditPresenterTest.kt
View file

@ -107,7 +107,7 @@ class RoomDetailsEditPresenterTest {
AvatarAction.TakePhoto,
AvatarAction.Remove
)
assertThat(initialState.saveButtonEnabled).isEqualTo(false)
assertThat(initialState.saveButtonEnabled).isFalse()
assertThat(initialState.saveAction).isInstanceOf(Async.Uninitialized::class.java)
}
}
@ -299,7 +299,7 @@ class RoomDetailsEditPresenterTest {
presenter.present()
}.test {
val initialState = awaitItem()
assertThat(initialState.saveButtonEnabled).isEqualTo(false)
assertThat(initialState.saveButtonEnabled).isFalse()
// Once a change is made, the save button is enabled
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name II"))
@ -310,7 +310,7 @@ class RoomDetailsEditPresenterTest {
// If it's reverted then the save disables again
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name"))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
// Make a change...
@ -322,7 +322,7 @@ class RoomDetailsEditPresenterTest {
// Revert it...
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomTopic("My topic"))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
// Make a change...
@ -334,7 +334,7 @@ class RoomDetailsEditPresenterTest {
// Revert it...
initialState.eventSink(RoomDetailsEditEvents.HandleAvatarAction(AvatarAction.ChoosePhoto))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
}
}
@ -351,7 +351,7 @@ class RoomDetailsEditPresenterTest {
presenter.present()
}.test {
val initialState = awaitItem()
assertThat(initialState.saveButtonEnabled).isEqualTo(false)
assertThat(initialState.saveButtonEnabled).isFalse()
// Once a change is made, the save button is enabled
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("Name II"))
@ -362,7 +362,7 @@ class RoomDetailsEditPresenterTest {
// If it's reverted then the save disables again
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomName("fallback"))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
// Make a change...
@ -374,7 +374,7 @@ class RoomDetailsEditPresenterTest {
// Revert it...
initialState.eventSink(RoomDetailsEditEvents.UpdateRoomTopic(""))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
// Make a change...
@ -386,7 +386,7 @@ class RoomDetailsEditPresenterTest {
// Revert it...
initialState.eventSink(RoomDetailsEditEvents.HandleAvatarAction(AvatarAction.Remove))
awaitItem().apply {
assertThat(saveButtonEnabled).isEqualTo(false)
assertThat(saveButtonEnabled).isFalse()
}
}
}