Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 9 Projects Releases Packages Wiki Activity Actions

Potential fix for pull request finding

Browse source 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Hugh Nimmo-Smith 2026-05-18 11:51:23 +01:00 • committed by GitHub
parent 7d6126409f
commit 65f2fd6cb8
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationService.kt
View file

@ -434,8 +434,9 @@ class RustMatrixAuthenticationService(
qrCodeData: QrCodeData, qrCodeData: QrCodeData,
): Client { ): Client {
Timber.d("Creating client for QR Code login with simplified sliding sync") Timber.d("Creating client for QR Code login with simplified sliding sync")
// The 2025 version of MSC4108 will always give us the baseUrl and guarantees it to be a well-formed URL // The 2025 version of MSC4108 provides baseUrl; the 2024 version has null baseUrl and uses
// The 2024 version always has null baseUrl and uses the serverName instead, which can be null or malformed // serverName instead, which can be null or malformed. We only enforce presence/non-blankness
// here and rely on serverNameOrHomeserverUrl()/the Rust builder layer to validate structure.
val baseUrlOrServerName = qrCodeData.baseUrl() ?: qrCodeData.serverName() val baseUrlOrServerName = qrCodeData.baseUrl() ?: qrCodeData.serverName()
if (baseUrlOrServerName == null) { if (baseUrlOrServerName == null) {