Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix warning and also fix bug!

Browse source
This commit is contained in:
Benoit Marty 2025-10-17 10:52:41 +02:00 • committed by Benoit Marty
parent 9094f2e823
commit 6854f014b0
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
libraries/featureflag/impl/src/main/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagService.kt
View file

@ -27,16 +27,14 @@ class DefaultFeatureFlagService(
) : FeatureFlagService { ) : FeatureFlagService {
override fun isFeatureEnabledFlow(feature: Feature): Flow<Boolean> { override fun isFeatureEnabledFlow(feature: Feature): Flow<Boolean> {
return providers.filter { it.hasFeature(feature) } return providers.filter { it.hasFeature(feature) }
.sortedByDescending(FeatureFlagProvider::priority) .maxByOrNull(FeatureFlagProvider::priority)
.firstOrNull()
?.isFeatureEnabledFlow(feature) ?.isFeatureEnabledFlow(feature)
?: flowOf(feature.defaultValue(buildMeta)) ?: flowOf(feature.defaultValue(buildMeta))
} }
override suspend fun setFeatureEnabled(feature: Feature, enabled: Boolean): Boolean { override suspend fun setFeatureEnabled(feature: Feature, enabled: Boolean): Boolean {
return providers.filterIsInstance<MutableFeatureFlagProvider>() return providers.filterIsInstance<MutableFeatureFlagProvider>()
.sortedBy(FeatureFlagProvider::priority) .maxByOrNull(FeatureFlagProvider::priority)
.firstOrNull()
?.setFeatureEnabled(feature, enabled) ?.setFeatureEnabled(feature, enabled)
?.let { true } ?.let { true }
?: false ?: false