Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix typo.

Browse source
This commit is contained in:
Benoit Marty 2025-10-17 14:52:06 +02:00
parent e5a9e2dc74
commit 6e722a2998
4 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlagService.kt
View file

@ -36,11 +36,11 @@ interface FeatureFlagService {
/** /**
* @return the list of available features that can be toggled. * @return the list of available features that can be toggled.
* @param includeFinishFeatures whether to include finished features, default is false * @param includeFinishedFeatures whether to include finished features, default is false
* @param isInLabs whether the user is in labs (to include lab features), default is false * @param isInLabs whether the user is in labs (to include lab features), default is false
*/ */
fun getAvailableFeatures( fun getAvailableFeatures(
includeFinishFeatures: Boolean = false, includeFinishedFeatures: Boolean = false,
isInLabs: Boolean = false, isInLabs: Boolean = false,
): List<Feature> ): List<Feature>
} }

4
libraries/featureflag/impl/src/main/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagService.kt
View file

@ -41,11 +41,11 @@ class DefaultFeatureFlagService(
} }
override fun getAvailableFeatures( override fun getAvailableFeatures(
includeFinishFeatures: Boolean, includeFinishedFeatures: Boolean,
isInLabs: Boolean, isInLabs: Boolean,
): List<Feature> { ): List<Feature> {
return featuresProvider.provide().filter { flag -> return featuresProvider.provide().filter { flag ->
(includeFinishFeatures || !flag.isFinished) && (includeFinishedFeatures || !flag.isFinished) &&
flag.isInLabs == isInLabs flag.isInLabs == isInLabs
} }
} }

8
libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt
View file

@ -133,25 +133,25 @@ class DefaultFeatureFlagServiceTest {
) )
assertThat( assertThat(
featureFlagService.getAvailableFeatures( featureFlagService.getAvailableFeatures(
includeFinishFeatures = false, includeFinishedFeatures = false,
isInLabs = true, isInLabs = true,
) )
).containsExactly(anUnfinishedLabFeature) ).containsExactly(anUnfinishedLabFeature)
assertThat( assertThat(
featureFlagService.getAvailableFeatures( featureFlagService.getAvailableFeatures(
includeFinishFeatures = true, includeFinishedFeatures = true,
isInLabs = true, isInLabs = true,
) )
).containsExactly(aFinishedLabFeature, anUnfinishedLabFeature) ).containsExactly(aFinishedLabFeature, anUnfinishedLabFeature)
assertThat( assertThat(
featureFlagService.getAvailableFeatures( featureFlagService.getAvailableFeatures(
includeFinishFeatures = false, includeFinishedFeatures = false,
isInLabs = false, isInLabs = false,
) )
).containsExactly(anUnfinishedDevFeature) ).containsExactly(anUnfinishedDevFeature)
assertThat( assertThat(
featureFlagService.getAvailableFeatures( featureFlagService.getAvailableFeatures(
includeFinishFeatures = true, includeFinishedFeatures = true,
isInLabs = false, isInLabs = false,
) )
).containsExactly(aFinishedDevFeature, anUnfinishedDevFeature) ).containsExactly(aFinishedDevFeature, anUnfinishedDevFeature)

4
libraries/featureflag/test/src/main/java/io/element/android/libraries/featureflag/test/FakeFeatureFlagService.kt
View file

@ -34,9 +34,9 @@ class FakeFeatureFlagService(
} }
override fun getAvailableFeatures( override fun getAvailableFeatures(
includeFinishFeatures: Boolean, includeFinishedFeatures: Boolean,
isInLabs: Boolean, isInLabs: Boolean,
): List<Feature> { ): List<Feature> {
return getAvailableFeaturesResult(includeFinishFeatures, isInLabs) return getAvailableFeaturesResult(includeFinishedFeatures, isInLabs)
} }
} }