Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add JoinedRoom posthog event (#687)

Browse source
This commit is contained in:
Yoan Pintas 2023-06-27 18:32:20 +02:00 • committed by GitHub
parent a16335b4b7
commit 710c3b279a
5 changed files with 66 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
features/invitelist/impl/src/main/kotlin/io/element/android/features/invitelist/impl/InviteListPresenter.kt
View file

@ -25,6 +25,7 @@ import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue
import im.vector.app.features.analytics.plan.JoinedRoom
import io.element.android.features.invitelist.api.SeenInvitesStore
import io.element.android.features.invitelist.impl.model.InviteListInviteSummary
import io.element.android.features.invitelist.impl.model.InviteSender
@ -35,6 +36,8 @@ import io.element.android.libraries.designsystem.components.avatar.AvatarData
import io.element.android.libraries.matrix.api.MatrixClient
import io.element.android.libraries.matrix.api.core.RoomId
import io.element.android.libraries.matrix.api.room.RoomSummary
import io.element.android.services.analytics.api.AnalyticsService
import io.element.android.services.analytics.api.extensions.toAnalyticsJoinedRoom
import kotlinx.collections.immutable.toPersistentList
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.flow.first
@ -44,6 +47,7 @@ import javax.inject.Inject
class InviteListPresenter @Inject constructor(
private val client: MatrixClient,
private val store: SeenInvitesStore,
private val analyticsService: AnalyticsService,
) : Presenter<InviteListState> {
@Composable
@ -133,6 +137,7 @@ class InviteListPresenter @Inject constructor(
suspend {
client.getRoom(roomId)?.use {
it.acceptInvitation().getOrThrow()
analyticsService.capture(it.toAnalyticsJoinedRoom(JoinedRoom.Trigger.Invite))
}
roomId
}.runCatchingUpdatingState(acceptedAction)

21
features/invitelist/impl/src/test/kotlin/io/element/android/features/invitelist/impl/InviteListPresenterTests.kt
View file

@ -20,6 +20,7 @@ import app.cash.molecule.RecompositionClock
import app.cash.molecule.moleculeFlow
import app.cash.turbine.test
import com.google.common.truth.Truth
import io.element.android.features.analytics.test.FakeAnalyticsService
import io.element.android.features.invitelist.test.FakeSeenInvitesStore
import io.element.android.libraries.architecture.Async
import io.element.android.libraries.designsystem.components.avatar.AvatarData
@ -50,6 +51,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
),
FakeSeenInvitesStore(),
FakeAnalyticsService(),
)
moleculeFlow(RecompositionClock.Immediate) {
presenter.present()
@ -74,6 +76,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
),
FakeSeenInvitesStore(),
FakeAnalyticsService(),
)
moleculeFlow(RecompositionClock.Immediate) {
presenter.present()
@ -102,6 +105,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
),
FakeSeenInvitesStore(),
FakeAnalyticsService(),
)
moleculeFlow(RecompositionClock.Immediate) {
presenter.present()
@ -128,6 +132,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
),
FakeSeenInvitesStore(),
FakeAnalyticsService(),
)
moleculeFlow(RecompositionClock.Immediate) {
presenter.present()
@ -152,6 +157,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
),
FakeSeenInvitesStore(),
FakeAnalyticsService(),
)
moleculeFlow(RecompositionClock.Immediate) {
presenter.present()
@ -176,6 +182,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
),
FakeSeenInvitesStore(),
FakeAnalyticsService(),
)
moleculeFlow(RecompositionClock.Immediate) {
presenter.present()
@ -199,7 +206,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
)
val room = FakeMatrixRoom()
val presenter = InviteListPresenter(client, FakeSeenInvitesStore())
val presenter = InviteListPresenter(client, FakeSeenInvitesStore(), FakeAnalyticsService())
client.givenGetRoomResult(A_ROOM_ID, room)
moleculeFlow(RecompositionClock.Immediate) {
@ -225,7 +232,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
)
val room = FakeMatrixRoom()
val presenter = InviteListPresenter(client, FakeSeenInvitesStore())
val presenter = InviteListPresenter(client, FakeSeenInvitesStore(), FakeAnalyticsService())
val ex = Throwable("Ruh roh!")
room.givenRejectInviteResult(Result.failure(ex))
client.givenGetRoomResult(A_ROOM_ID, room)
@ -256,7 +263,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
)
val room = FakeMatrixRoom()
val presenter = InviteListPresenter(client, FakeSeenInvitesStore())
val presenter = InviteListPresenter(client, FakeSeenInvitesStore(), FakeAnalyticsService())
val ex = Throwable("Ruh roh!")
room.givenRejectInviteResult(Result.failure(ex))
client.givenGetRoomResult(A_ROOM_ID, room)
@ -288,7 +295,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
)
val room = FakeMatrixRoom()
val presenter = InviteListPresenter(client, FakeSeenInvitesStore())
val presenter = InviteListPresenter(client, FakeSeenInvitesStore(), FakeAnalyticsService())
client.givenGetRoomResult(A_ROOM_ID, room)
moleculeFlow(RecompositionClock.Immediate) {
@ -311,7 +318,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
)
val room = FakeMatrixRoom()
val presenter = InviteListPresenter(client, FakeSeenInvitesStore())
val presenter = InviteListPresenter(client, FakeSeenInvitesStore(), FakeAnalyticsService())
val ex = Throwable("Ruh roh!")
room.givenAcceptInviteResult(Result.failure(ex))
client.givenGetRoomResult(A_ROOM_ID, room)
@ -336,7 +343,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
)
val room = FakeMatrixRoom()
val presenter = InviteListPresenter(client, FakeSeenInvitesStore())
val presenter = InviteListPresenter(client, FakeSeenInvitesStore(), FakeAnalyticsService())
val ex = Throwable("Ruh roh!")
room.givenAcceptInviteResult(Result.failure(ex))
client.givenGetRoomResult(A_ROOM_ID, room)
@ -365,6 +372,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
),
store,
FakeAnalyticsService(),
)
moleculeFlow(RecompositionClock.Immediate) {
presenter.present()
@ -401,6 +409,7 @@ class InviteListPresenterTests {
invitesDataSource = invitesDataSource,
),
store,
FakeAnalyticsService(),
)
moleculeFlow(RecompositionClock.Immediate) {
presenter.present()