Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Use the right analytics span as a parent in checkNetworkConnection (#6751)

Browse source 
`AnalyticsLongRunningTransaction.PushToWorkManager` was incorrectly used instead of `AnalyticsLongRunningTransaction.PushToNotification`, resulting in wrongly formatter analytic traces
This commit is contained in:
Jorge Martin Espinosa 2026-05-12 15:04:13 +02:00 • committed by GitHub
parent bc24bb4e88
commit 738811b297
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/workmanager/FetchPendingNotificationsWorker.kt
View file

@ -153,7 +153,7 @@ class FetchPendingNotificationsWorker(
private suspend fun checkNetworkConnection(requests: List<PushRequest>): Result? { private suspend fun checkNetworkConnection(requests: List<PushRequest>): Result? {
val networkTimeoutSpans = requests.mapNotNull { request -> val networkTimeoutSpans = requests.mapNotNull { request ->
val parent = analyticsService.getLongRunningTransaction(AnalyticsLongRunningTransaction.PushToWorkManager(request.eventId)) val parent = analyticsService.getLongRunningTransaction(AnalyticsLongRunningTransaction.PushToNotification(request.eventId))
parent?.startChild("Waiting for network connectivity", "await_network") parent?.startChild("Waiting for network connectivity", "await_network")
} }