Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Make ChangeServerPresenter.submit fail as expected (#236)

Browse source 
* Make `ChangeServerPresenter.submit` fail as expected

* Fix tests to prevent this from ever happening again
This commit is contained in:
Jorge Martin Espinosa 2023-03-23 15:19:18 +01:00 • committed by GitHub
parent fc73b2b8f9
commit 76ade37355
3 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

11
libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/auth/FakeAuthenticationService.kt
View file

@ -53,20 +53,13 @@ class FakeAuthenticationService : MatrixAuthenticationService {
}
override suspend fun setHomeserver(homeserver: String): Result<Unit> {
changeServerError?.let { throw it }
delay(100)
return Result.success(Unit)
return changeServerError?.let { Result.failure(it) } ?: Result.success(Unit)
}
override suspend fun login(username: String, password: String): Result<SessionId> {
delay(100)
return loginError.let { loginError ->
if (loginError == null) {
Result.success(A_USER_ID)
} else {
Result.failure(loginError)
}
}
return loginError?.let { Result.failure(it) } ?: Result.success(A_USER_ID)
}
fun givenLoginError(throwable: Throwable?) {