Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix test now that the send button is always enabled but can fail if description is too short.

Browse source
This commit is contained in:
Benoit Marty 2024-02-06 09:01:59 +01:00
parent 021509ad17
commit 796fb9b483
1 changed files with 27 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

29
features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/bugreport/BugReportPresenterTest.kt
View file

@ -54,7 +54,7 @@ class BugReportPresenterTest {
assertThat(initialState.sending).isEqualTo(AsyncAction.Uninitialized) assertThat(initialState.sending).isEqualTo(AsyncAction.Uninitialized)
assertThat(initialState.screenshotUri).isNull() assertThat(initialState.screenshotUri).isNull()
assertThat(initialState.sendingProgress).isEqualTo(0f) assertThat(initialState.sendingProgress).isEqualTo(0f)
assertThat(initialState.submitEnabled).isFalse() assertThat(initialState.submitEnabled).isTrue()
} }
} }
@ -66,7 +66,7 @@ class BugReportPresenterTest {
}.test { }.test {
val initialState = awaitItem() val initialState = awaitItem()
initialState.eventSink.invoke(BugReportEvents.SetDescription(A_SHORT_DESCRIPTION)) initialState.eventSink.invoke(BugReportEvents.SetDescription(A_SHORT_DESCRIPTION))
assertThat(awaitItem().submitEnabled).isFalse() assertThat(awaitItem().submitEnabled).isTrue()
initialState.eventSink.invoke(BugReportEvents.SetDescription(A_LONG_DESCRIPTION)) initialState.eventSink.invoke(BugReportEvents.SetDescription(A_LONG_DESCRIPTION))
assertThat(awaitItem().submitEnabled).isTrue() assertThat(awaitItem().submitEnabled).isTrue()
} }
@ -146,6 +146,8 @@ class BugReportPresenterTest {
presenter.present() presenter.present()
}.test { }.test {
val initialState = awaitItem() val initialState = awaitItem()
initialState.eventSink.invoke(BugReportEvents.SetDescription(A_LONG_DESCRIPTION))
skipItems(1)
initialState.eventSink.invoke(BugReportEvents.SendBugReport) initialState.eventSink.invoke(BugReportEvents.SendBugReport)
skipItems(1) skipItems(1)
val progressState = awaitItem() val progressState = awaitItem()
@ -170,6 +172,8 @@ class BugReportPresenterTest {
presenter.present() presenter.present()
}.test { }.test {
val initialState = awaitItem() val initialState = awaitItem()
initialState.eventSink.invoke(BugReportEvents.SetDescription(A_LONG_DESCRIPTION))
skipItems(1)
initialState.eventSink.invoke(BugReportEvents.SendBugReport) initialState.eventSink.invoke(BugReportEvents.SendBugReport)
skipItems(1) skipItems(1)
val progressState = awaitItem() val progressState = awaitItem()
@ -187,6 +191,25 @@ class BugReportPresenterTest {
} }
} }
@Test
fun `present - send failure description too short`() = runTest {
val presenter = createPresenter()
moleculeFlow(RecompositionMode.Immediate) {
presenter.present()
}.test {
val initialState = awaitItem()
initialState.eventSink.invoke(BugReportEvents.SetDescription(A_SHORT_DESCRIPTION))
skipItems(1)
initialState.eventSink.invoke(BugReportEvents.SendBugReport)
val errorState = awaitItem()
assertThat(errorState.sending).isEqualTo(AsyncAction.Failure(BugReportFormError.DescriptionTooShort))
// Reset failure
initialState.eventSink.invoke(BugReportEvents.ClearError)
val lastItem = awaitItem()
assertThat(lastItem.sending).isInstanceOf(AsyncAction.Uninitialized::class.java)
}
}
@Test @Test
fun `present - send cancel`() = runTest { fun `present - send cancel`() = runTest {
val presenter = createPresenter( val presenter = createPresenter(
@ -198,6 +221,8 @@ class BugReportPresenterTest {
presenter.present() presenter.present()
}.test { }.test {
val initialState = awaitItem() val initialState = awaitItem()
initialState.eventSink.invoke(BugReportEvents.SetDescription(A_LONG_DESCRIPTION))
skipItems(1)
initialState.eventSink.invoke(BugReportEvents.SendBugReport) initialState.eventSink.invoke(BugReportEvents.SendBugReport)
skipItems(1) skipItems(1)
val progressState = awaitItem() val progressState = awaitItem()