Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Add Modifier parameter and make internal Composable private.

Browse source
This commit is contained in:
Benoit Marty 2023-06-16 15:27:09 +02:00
parent b61ad40c65
commit 7a1416aad4
1 changed files with 20 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

28
features/analytics/impl/src/main/kotlin/io/element/android/features/analytics/impl/AnalyticsOptInView.kt
View file

@ -82,11 +82,15 @@ fun AnalyticsOptInView(
} }
@Composable @Composable
fun AnalyticsOptInHeader( private fun AnalyticsOptInHeader(
state: AnalyticsOptInState, state: AnalyticsOptInState,
onClickTerms: () -> Unit, onClickTerms: () -> Unit,
modifier: Modifier = Modifier,
) { ) {
Column(horizontalAlignment = Alignment.CenterHorizontally) { Column(
modifier = modifier,
horizontalAlignment = Alignment.CenterHorizontally,
) {
IconTitleSubtitleMolecule( IconTitleSubtitleMolecule(
modifier = Modifier.padding(top = 60.dp, bottom = 12.dp), modifier = Modifier.padding(top = 60.dp, bottom = 12.dp),
title = stringResource(id = R.string.screen_analytics_prompt_title, state.applicationName), title = stringResource(id = R.string.screen_analytics_prompt_title, state.applicationName),
@ -113,9 +117,11 @@ fun AnalyticsOptInHeader(
} }
@Composable @Composable
fun AnalyticsOptInContent() { private fun AnalyticsOptInContent(
modifier: Modifier = Modifier,
) {
Box( Box(
modifier = Modifier.fillMaxSize(), modifier = modifier.fillMaxSize(),
contentAlignment = BiasAlignment( contentAlignment = BiasAlignment(
horizontalBias = 0f, horizontalBias = 0f,
verticalBias = -0.4f verticalBias = -0.4f
@ -141,9 +147,10 @@ fun AnalyticsOptInContent() {
} }
@Composable @Composable
fun AnalyticsOptInContentRow( private fun AnalyticsOptInContentRow(
text: String, text: String,
idx: Int, idx: Int,
modifier: Modifier = Modifier,
) { ) {
val radius = 14.dp val radius = 14.dp
val bgShape = when (idx) { val bgShape = when (idx) {
@ -152,7 +159,7 @@ fun AnalyticsOptInContentRow(
else -> RoundedCornerShape(0.dp) else -> RoundedCornerShape(0.dp)
} }
Row( Row(
modifier = Modifier modifier = modifier
.fillMaxWidth() .fillMaxWidth()
.background( .background(
color = LocalColors.current.quinary, color = LocalColors.current.quinary,
@ -181,8 +188,13 @@ fun AnalyticsOptInContentRow(
} }
@Composable @Composable
fun AnalyticsOptInFooter(eventSink: (AnalyticsOptInEvents) -> Unit) { private fun AnalyticsOptInFooter(
ButtonColumnMolecule { eventSink: (AnalyticsOptInEvents) -> Unit,
modifier: Modifier = Modifier,
) {
ButtonColumnMolecule(
modifier = modifier,
) {
Button( Button(
onClick = { eventSink(AnalyticsOptInEvents.EnableAnalytics(true)) }, onClick = { eventSink(AnalyticsOptInEvents.EnableAnalytics(true)) },
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),