Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix the test according to the behavior change.

Browse source
This commit is contained in:
Benoit Marty 2024-09-04 12:23:52 +02:00
parent 264d1bc694
commit 7db5ac8195
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushGatewayResolverTest.kt
View file

@ -95,7 +95,7 @@ class DefaultUnifiedPushGatewayResolverTest {
} }
@Test @Test
fun `when a custom url is not reachable, the default url is returned`() = runTest { fun `when a custom url is not reachable, the custom url is still returned`() = runTest {
val unifiedPushApiFactory = FakeUnifiedPushApiFactory( val unifiedPushApiFactory = FakeUnifiedPushApiFactory(
discoveryResponse = { throw AN_EXCEPTION } discoveryResponse = { throw AN_EXCEPTION }
) )
@ -104,7 +104,7 @@ class DefaultUnifiedPushGatewayResolverTest {
) )
val result = sut.getGateway("http://custom.url") val result = sut.getGateway("http://custom.url")
assertThat(unifiedPushApiFactory.baseUrlParameter).isEqualTo("http://custom.url") assertThat(unifiedPushApiFactory.baseUrlParameter).isEqualTo("http://custom.url")
assertThat(result).isEqualTo(UnifiedPushConfig.DEFAULT_PUSH_GATEWAY_HTTP_URL) assertThat(result).isEqualTo("http://custom.url/_matrix/push/v1/notify")
} }
@Test @Test
@ -121,7 +121,7 @@ class DefaultUnifiedPushGatewayResolverTest {
} }
@Test @Test
fun `when a custom url provides a invalid matrix gateway, the default url is returned`() = runTest { fun `when a custom url provides a invalid matrix gateway, the custom url is still returned`() = runTest {
val unifiedPushApiFactory = FakeUnifiedPushApiFactory( val unifiedPushApiFactory = FakeUnifiedPushApiFactory(
discoveryResponse = invalidDiscoveryResponse discoveryResponse = invalidDiscoveryResponse
) )
@ -130,7 +130,7 @@ class DefaultUnifiedPushGatewayResolverTest {
) )
val result = sut.getGateway("https://custom.url") val result = sut.getGateway("https://custom.url")
assertThat(unifiedPushApiFactory.baseUrlParameter).isEqualTo("https://custom.url") assertThat(unifiedPushApiFactory.baseUrlParameter).isEqualTo("https://custom.url")
assertThat(result).isEqualTo(UnifiedPushConfig.DEFAULT_PUSH_GATEWAY_HTTP_URL) assertThat(result).isEqualTo("https://custom.url/_matrix/push/v1/notify")
} }
private fun TestScope.createDefaultUnifiedPushGatewayResolver( private fun TestScope.createDefaultUnifiedPushGatewayResolver(