Update plugin ktlint to v12.1.0 (#2200)

* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>

features/location/api/src/main/kotlin/io/element/android/features/location/api/internal/MapTilerStaticMapUrlBuilder.kt

@@ -65,7 +65,7 @@ internal class MapTilerStaticMapUrlBuilder(
         // image smaller than the available space in pixels.
         // The resulting image will have to be scaled to fit the available space in order
         // to keep the perceived content size constant at the expense of sharpness.
-        return "$MAPTILER_BASE_URL/${mapId}/static/${lon},${lat},${finalZoom}/${finalWidth}x${finalHeight}${scale}.webp?key=${apiKey}&attribution=bottomleft"
+        return "$MAPTILER_BASE_URL/$mapId/static/$lon,$lat,$finalZoom/${finalWidth}x${finalHeight}$scale.webp?key=$apiKey&attribution=bottomleft"
     }
 }
 

features/location/api/src/main/kotlin/io/element/android/features/location/api/internal/MapTilerTileServerStyleUriBuilder.kt

@@ -34,6 +34,6 @@ internal class MapTilerTileServerStyleUriBuilder(
 
     override fun build(darkMode: Boolean): String {
         val mapId = if (darkMode) darkMapId else lightMapId
-        return "${MAPTILER_BASE_URL}/${mapId}/style.json?key=${apiKey}"
+        return "$MAPTILER_BASE_URL/$mapId/style.json?key=$apiKey"
     }
 }

features/location/api/src/test/kotlin/io/element/android/features/location/api/LocationKtTest.kt

@@ -78,7 +78,7 @@ internal class LocationKtTest {
 
     @Test
     fun `encode geoUri - returns geoUri from a Location`() {
-        assertThat(Location(1.0,2.0,3.0f).toGeoUri())
+        assertThat(Location(1.0, 2.0, 3.0f).toGeoUri())
             .isEqualTo("geo:1.0,2.0;u=3.0")
     }
 }

features/location/impl/src/main/kotlin/io/element/android/features/location/impl/send/SendLocationEntryPointImpl.kt

@@ -27,6 +27,7 @@ import javax.inject.Inject
 @ContributesBinding(AppScope::class)
 class SendLocationEntryPointImpl @Inject constructor() : SendLocationEntryPoint {
     override fun createNode(
-        parentNode: Node, buildContext: BuildContext
+        parentNode: Node,
+        buildContext: BuildContext
     ): SendLocationNode = parentNode.createNode(buildContext)
 }

features/location/impl/src/main/kotlin/io/element/android/features/location/impl/send/SendLocationPresenter.kt

@@ -55,8 +55,11 @@ class SendLocationPresenter @Inject constructor(
         val permissionsState: PermissionsState = permissionsPresenter.present()
         var mode: SendLocationState.Mode by remember {
             mutableStateOf(
-                if (permissionsState.isAnyGranted) SendLocationState.Mode.SenderLocation
-                else SendLocationState.Mode.PinLocation
+                if (permissionsState.isAnyGranted) {
+                    SendLocationState.Mode.SenderLocation
+                } else {
+                    SendLocationState.Mode.PinLocation
+                }
             )
         }
         val appName by remember { derivedStateOf { buildMeta.applicationName } }

features/location/impl/src/test/kotlin/io/element/android/features/location/impl/send/SendLocationPresenterTest.kt

@@ -75,7 +75,6 @@ class SendLocationPresenterTest {
         moleculeFlow(RecompositionMode.Immediate) {
             sendLocationPresenter.present()
         }.test {
-
             val initialState = awaitItem()
             assertThat(initialState.permissionDialog).isEqualTo(SendLocationState.Dialog.None)
             assertThat(initialState.mode).isEqualTo(SendLocationState.Mode.SenderLocation)
@@ -102,7 +101,6 @@ class SendLocationPresenterTest {
         moleculeFlow(RecompositionMode.Immediate) {
             sendLocationPresenter.present()
         }.test {
-
             val initialState = awaitItem()
             assertThat(initialState.permissionDialog).isEqualTo(SendLocationState.Dialog.None)
             assertThat(initialState.mode).isEqualTo(SendLocationState.Mode.SenderLocation)
@@ -381,7 +379,9 @@ class SendLocationPresenterTest {
         )
         fakeMessageComposerContext.apply {
             composerMode = MessageComposerMode.Edit(
-                eventId = null, defaultContent = "", transactionId = null
+                eventId = null,
+                defaultContent = "",
+                transactionId = null
             )
         }
 
@@ -427,7 +427,9 @@ class SendLocationPresenterTest {
         )
         fakeMessageComposerContext.apply {
             composerMode = MessageComposerMode.Edit(
-                eventId = null, defaultContent = "", transactionId = null
+                eventId = null,
+                defaultContent = "",
+                transactionId = null
             )
         }