Rename file and split test.

This commit is contained in:
Benoit Marty 2024-11-29 09:41:03 +01:00 committed by Benoit Marty
parent 05b65f3ec3
commit 81679cceae
4 changed files with 24 additions and 9 deletions

View file

@ -8,13 +8,12 @@
package io.element.android.libraries.mediaviewer.impl.util package io.element.android.libraries.mediaviewer.impl.util
import com.google.common.truth.Truth.assertThat import com.google.common.truth.Truth.assertThat
import io.element.android.libraries.mediaviewer.test.util.FileExtensionExtractorWithoutValidation
import org.junit.Test import org.junit.Test
import org.junit.runner.RunWith import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner import org.robolectric.RobolectricTestRunner
@RunWith(RobolectricTestRunner::class) @RunWith(RobolectricTestRunner::class)
class FileExtensionExtractorTest { class FileExtensionExtractorWithValidationTest {
@Test @Test
fun `test FileExtensionExtractor with validation OK`() { fun `test FileExtensionExtractor with validation OK`() {
val sut = FileExtensionExtractorWithValidation() val sut = FileExtensionExtractorWithValidation()
@ -28,11 +27,4 @@ class FileExtensionExtractorTest {
val sut = FileExtensionExtractorWithValidation() val sut = FileExtensionExtractorWithValidation()
assertThat(sut.extractFromName("test.bla")).isEqualTo("bin") assertThat(sut.extractFromName("test.bla")).isEqualTo("bin")
} }
@Test
fun `test FileExtensionExtractor no validation`() {
val sut = FileExtensionExtractorWithoutValidation()
assertThat(sut.extractFromName("test.png")).isEqualTo("png")
assertThat(sut.extractFromName("test.bla")).isEqualTo("bla")
}
} }

View file

@ -18,4 +18,7 @@ dependencies {
implementation(projects.libraries.core) implementation(projects.libraries.core)
implementation(projects.tests.testutils) implementation(projects.tests.testutils)
implementation(projects.libraries.matrix.api) implementation(projects.libraries.matrix.api)
testImplementation(libs.test.junit)
testImplementation(libs.test.truth)
} }

View file

@ -0,0 +1,20 @@
/*
* Copyright 2024 New Vector Ltd.
*
* SPDX-License-Identifier: AGPL-3.0-only
* Please see LICENSE in the repository root for full details.
*/
package io.element.android.libraries.mediaviewer.test.util
import com.google.common.truth.Truth.assertThat
import org.junit.Test
class FileExtensionExtractorWithoutValidationTest {
@Test
fun `extension should always be extracted even is invalid`() {
val sut = FileExtensionExtractorWithoutValidation()
assertThat(sut.extractFromName("test.png")).isEqualTo("png")
assertThat(sut.extractFromName("test.bla")).isEqualTo("bla")
}
}