Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Move AppErrorView to the api module so that :appnav:root does not have to depend on a impl module.

Browse source
This commit is contained in:
Benoit Marty 2026-04-08 17:29:29 +02:00
parent 8d80db199e
commit 8696b7361f
5 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
appnav/build.gradle.kts
View file

@ -51,7 +51,7 @@ dependencies {
implementation(projects.features.linknewdevice.api) implementation(projects.features.linknewdevice.api)
implementation(projects.features.share.api) implementation(projects.features.share.api)
implementation(projects.services.apperror.impl) implementation(projects.services.apperror.api)
implementation(projects.services.appnavstate.api) implementation(projects.services.appnavstate.api)
implementation(projects.services.analytics.api) implementation(projects.services.analytics.api)

2
appnav/src/main/kotlin/io/element/android/appnav/root/RootView.kt
View file

@ -22,7 +22,7 @@ import io.element.android.features.rageshake.api.detection.RageshakeDetectionVie
import io.element.android.libraries.designsystem.preview.ElementPreview import io.element.android.libraries.designsystem.preview.ElementPreview
import io.element.android.libraries.designsystem.preview.PreviewsDayNight import io.element.android.libraries.designsystem.preview.PreviewsDayNight
import io.element.android.libraries.designsystem.theme.components.Text import io.element.android.libraries.designsystem.theme.components.Text
import io.element.android.services.apperror.impl.AppErrorView import io.element.android.services.apperror.api.AppErrorView
@Composable @Composable
fun RootView( fun RootView(

1
services/apperror/api/build.gradle.kts
View file

@ -16,4 +16,5 @@ android {
dependencies { dependencies {
implementation(libs.coroutines.core) implementation(libs.coroutines.core)
implementation(projects.libraries.designsystem)
} }

4
services/apperror/impl/src/main/kotlin/io/element/android/services/apperror/impl/AppErrorView.kt → services/apperror/api/src/main/kotlin/io/element/android/services/apperror/api/AppErrorView.kt
View file

@ -6,14 +6,12 @@
* Please see LICENSE files in the repository root for full details. * Please see LICENSE files in the repository root for full details.
*/ */
package io.element.android.services.apperror.impl package io.element.android.services.apperror.api
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import io.element.android.libraries.designsystem.components.dialogs.ErrorDialog import io.element.android.libraries.designsystem.components.dialogs.ErrorDialog
import io.element.android.libraries.designsystem.preview.ElementPreview import io.element.android.libraries.designsystem.preview.ElementPreview
import io.element.android.libraries.designsystem.preview.PreviewsDayNight import io.element.android.libraries.designsystem.preview.PreviewsDayNight
import io.element.android.services.apperror.api.AppErrorState
import io.element.android.services.apperror.api.aAppErrorState
@Composable @Composable
fun AppErrorView( fun AppErrorView(

4
services/apperror/impl/build.gradle.kts
View file

@ -10,7 +10,7 @@ import extension.testCommonDependencies
*/ */
plugins { plugins {
id("io.element.android-compose-library") id("io.element.android-library")
} }
setupDependencyInjection() setupDependencyInjection()
@ -22,8 +22,6 @@ android {
dependencies { dependencies {
implementation(projects.libraries.core) implementation(projects.libraries.core)
implementation(projects.libraries.di) implementation(projects.libraries.di)
implementation(projects.libraries.designsystem)
implementation(projects.libraries.uiStrings)
implementation(projects.services.toolbox.api) implementation(projects.services.toolbox.api)
implementation(libs.coroutines.core) implementation(libs.coroutines.core)