Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 11 Projects Releases Packages Wiki Activity Actions

Lambda parameters in a composable function should be in present tense, not past tense.

Browse source 
https://mrmans0n.github.io/compose-rules/rules/#naming-parameters-properly
This commit is contained in:
Benoit Marty 2024-05-29 10:48:29 +02:00
parent b8f3b66d0e
commit 87689d787e
250 changed files with 1698 additions and 1698 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libraries/troubleshoot/impl/src/main/kotlin/io/element/android/libraries/troubleshoot/impl/TroubleshootNotificationsNode.kt
View file

@ -49,7 +49,7 @@ class TroubleshootNotificationsNode @AssistedInject constructor(
val state = presenter.present()
TroubleshootNotificationsView(
state = state,
onBackPressed = ::onDone,
onBackClick = ::onDone,
modifier = modifier,
)
}

18
libraries/troubleshoot/impl/src/main/kotlin/io/element/android/libraries/troubleshoot/impl/TroubleshootNotificationsView.kt
View file

@ -44,7 +44,7 @@ import io.element.android.libraries.troubleshoot.api.test.NotificationTroublesho
@Composable
fun TroubleshootNotificationsView(
state: TroubleshootNotificationsState,
onBackPressed: () -> Unit,
onBackClick: () -> Unit,
modifier: Modifier = Modifier,
) {
OnLifecycleEvent { _, event ->
@ -60,7 +60,7 @@ fun TroubleshootNotificationsView(
PreferencePage(
modifier = modifier,
onBackPressed = onBackPressed,
onBackClick = onBackClick,
title = stringResource(id = R.string.troubleshoot_notifications_screen_title),
) {
TroubleshootNotificationsContent(state)
@ -70,7 +70,7 @@ fun TroubleshootNotificationsView(
@Composable
private fun TroubleshootTestView(
testState: NotificationTroubleshootTestState,
onQuickFixClicked: () -> Unit,
onQuickFixClick: () -> Unit,
) {
if ((testState.status as? Status.Idle)?.visible == false) return
ListItem(
@ -119,7 +119,7 @@ private fun TroubleshootTestView(
trailingContent = ListItemContent.Custom {
Button(
text = stringResource(id = R.string.troubleshoot_notifications_screen_quick_fix_action),
onClick = onQuickFixClicked
onClick = onQuickFixClick
)
}
)
@ -135,7 +135,7 @@ private fun TroubleshootNotificationsContent(state: TroubleshootNotificationsSta
is AsyncAction.Failure -> {
TestSuiteView(
testSuiteState = state.testSuiteState,
onQuickFixClicked = {
onQuickFixClick = {
state.eventSink(TroubleshootNotificationsEvents.QuickFix(it))
}
)
@ -199,13 +199,13 @@ private fun RunTestButton(state: TroubleshootNotificationsState) {
@Composable
private fun TestSuiteView(
testSuiteState: TroubleshootTestSuiteState,
onQuickFixClicked: (Int) -> Unit,
onQuickFixClick: (Int) -> Unit,
) {
testSuiteState.tests.forEachIndexed { index, testState ->
TroubleshootTestView(
testState = testState,
onQuickFixClicked = {
onQuickFixClicked(index)
onQuickFixClick = {
onQuickFixClick(index)
},
)
}
@ -218,6 +218,6 @@ internal fun TroubleshootNotificationsViewPreview(
) = ElementPreview {
TroubleshootNotificationsView(
state = state,
onBackPressed = {},
onBackClick = {},
)
}

6
libraries/troubleshoot/impl/src/test/kotlin/io/element/android/libraries/troubleshoot/impl/TroubleshootNotificationsViewTest.kt
View file

@ -45,7 +45,7 @@ class TroubleshootNotificationsViewTest {
state = aTroubleshootNotificationsState(
eventSink = eventsRecorder
),
onBackPressed = it,
onBackClick = it,
)
rule.pressBack()
}
@ -112,12 +112,12 @@ class TroubleshootNotificationsViewTest {
private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setTroubleshootNotificationsView(
state: TroubleshootNotificationsState,
onBackPressed: () -> Unit = EnsureNeverCalled(),
onBackClick: () -> Unit = EnsureNeverCalled(),
) {
setContent {
TroubleshootNotificationsView(
state = state,
onBackPressed = onBackPressed,
onBackClick = onBackClick,
)
}
}