Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Perform toImmutableList() less often.

Browse source
This commit is contained in:
Benoit Marty 2025-10-17 11:42:21 +02:00 • committed by Benoit Marty
parent c98601c3c3
commit 87a1b79726
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/developer/DeveloperSettingsPresenter.kt
View file

@ -39,6 +39,7 @@ import io.element.android.libraries.featureflag.api.FeatureFlagService
import io.element.android.libraries.featureflag.api.FeatureFlags
import io.element.android.libraries.featureflag.ui.model.FeatureUiModel
import io.element.android.libraries.preferences.api.store.AppPreferencesStore
import kotlinx.collections.immutable.ImmutableList
import kotlinx.collections.immutable.persistentListOf
import kotlinx.collections.immutable.toImmutableList
import kotlinx.coroutines.CoroutineScope
@ -146,7 +147,7 @@ class DeveloperSettingsPresenter(
}
return DeveloperSettingsState(
features = featureUiModels.toImmutableList(),
features = featureUiModels,
cacheSize = cacheSize.value,
clearCacheAction = clearCacheAction.value,
rageshakeState = rageshakeState,
@ -165,7 +166,7 @@ class DeveloperSettingsPresenter(
@Composable
private fun createUiModels(
enabledFeatures: SnapshotStateList<EnabledFeature>,
): List<FeatureUiModel> {
): ImmutableList<FeatureUiModel> {
return enabledFeatures.map { enabledFeature ->
key(enabledFeature.feature.key) {
remember(enabledFeature) {
@ -178,7 +179,7 @@ class DeveloperSettingsPresenter(
)
}
}
}
}.toImmutableList()
}
private fun CoroutineScope.updateEnabledFeature(