Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

knock requests : rename fixture aKnockRequestPresentable

Browse source
This commit is contained in:
ganfra 2024-12-19 19:34:11 +01:00
parent c095457212
commit 87ce71a883
5 changed files with 34 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

20
features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/banner/KnockRequestsBannerStateProvider.kt
View file

@ -9,7 +9,7 @@ package io.element.android.features.knockrequests.impl.banner
import androidx.compose.ui.tooling.preview.PreviewParameterProvider import androidx.compose.ui.tooling.preview.PreviewParameterProvider
import io.element.android.features.knockrequests.impl.data.KnockRequestPresentable import io.element.android.features.knockrequests.impl.data.KnockRequestPresentable
import io.element.android.features.knockrequests.impl.data.aKnockRequest import io.element.android.features.knockrequests.impl.data.aKnockRequestPresentable
import kotlinx.collections.immutable.toImmutableList import kotlinx.collections.immutable.toImmutableList
class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsBannerState> { class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsBannerState> {
@ -18,7 +18,7 @@ class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsB
aKnockRequestsBannerState(), aKnockRequestsBannerState(),
aKnockRequestsBannerState( aKnockRequestsBannerState(
knockRequests = listOf( knockRequests = listOf(
aKnockRequest( aKnockRequestPresentable(
reason = "A very long reason that should probably be truncated, " + reason = "A very long reason that should probably be truncated, " +
"but could be also expanded so you can see it over the lines, wow," + "but could be also expanded so you can see it over the lines, wow," +
"very amazing reason, I know, right, I'm so good at writing reasons." "very amazing reason, I know, right, I'm so good at writing reasons."
@ -27,16 +27,16 @@ class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsB
), ),
aKnockRequestsBannerState( aKnockRequestsBannerState(
knockRequests = listOf( knockRequests = listOf(
aKnockRequest(), aKnockRequestPresentable(),
aKnockRequest(displayName = "Alice") aKnockRequestPresentable(displayName = "Alice")
) )
), ),
aKnockRequestsBannerState( aKnockRequestsBannerState(
knockRequests = listOf( knockRequests = listOf(
aKnockRequest(), aKnockRequestPresentable(),
aKnockRequest(displayName = "Alice"), aKnockRequestPresentable(displayName = "Alice"),
aKnockRequest(displayName = "Bob"), aKnockRequestPresentable(displayName = "Bob"),
aKnockRequest(displayName = "Charlie") aKnockRequestPresentable(displayName = "Charlie")
) )
), ),
aKnockRequestsBannerState( aKnockRequestsBannerState(
@ -47,7 +47,7 @@ class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsB
), ),
aKnockRequestsBannerState( aKnockRequestsBannerState(
knockRequests = listOf( knockRequests = listOf(
aKnockRequest( aKnockRequestPresentable(
displayName = "A_very_long_display_name_so_that_the_text_can_be_displayed_on_multiple_lines" displayName = "A_very_long_display_name_so_that_the_text_can_be_displayed_on_multiple_lines"
) )
) )
@ -56,7 +56,7 @@ class KnockRequestsBannerStateProvider : PreviewParameterProvider<KnockRequestsB
} }
fun aKnockRequestsBannerState( fun aKnockRequestsBannerState(
knockRequests: List<KnockRequestPresentable> = listOf(aKnockRequest()), knockRequests: List<KnockRequestPresentable> = listOf(aKnockRequestPresentable()),
displayAcceptError: Boolean = false, displayAcceptError: Boolean = false,
canAccept: Boolean = true, canAccept: Boolean = true,
isVisible: Boolean = true, isVisible: Boolean = true,

2
features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/data/KnockRequestFixture.kt
View file

@ -10,7 +10,7 @@ package io.element.android.features.knockrequests.impl.data
import io.element.android.libraries.matrix.api.core.EventId import io.element.android.libraries.matrix.api.core.EventId
import io.element.android.libraries.matrix.api.core.UserId import io.element.android.libraries.matrix.api.core.UserId
fun aKnockRequest( fun aKnockRequestPresentable(
eventId: EventId = EventId("\$eventId"), eventId: EventId = EventId("\$eventId"),
userId: UserId = UserId("@jacob_ross:example.com"), userId: UserId = UserId("@jacob_ross:example.com"),
displayName: String? = "Jacob Ross", displayName: String? = "Jacob Ross",

22
features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListStateProvider.kt
View file

@ -10,7 +10,7 @@ package io.element.android.features.knockrequests.impl.list
import androidx.compose.ui.tooling.preview.PreviewParameterProvider import androidx.compose.ui.tooling.preview.PreviewParameterProvider
import io.element.android.features.knockrequests.impl.data.KnockRequestPermissions import io.element.android.features.knockrequests.impl.data.KnockRequestPermissions
import io.element.android.features.knockrequests.impl.data.KnockRequestPresentable import io.element.android.features.knockrequests.impl.data.KnockRequestPresentable
import io.element.android.features.knockrequests.impl.data.aKnockRequest import io.element.android.features.knockrequests.impl.data.aKnockRequestPresentable
import io.element.android.libraries.architecture.AsyncAction import io.element.android.libraries.architecture.AsyncAction
import io.element.android.libraries.architecture.AsyncData import io.element.android.libraries.architecture.AsyncData
import io.element.android.libraries.matrix.api.core.UserId import io.element.android.libraries.matrix.api.core.UserId
@ -31,14 +31,14 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest() aKnockRequestPresentable()
) )
), ),
), ),
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest( aKnockRequestPresentable(
reason = "A very long reason that should probably be truncated, " + reason = "A very long reason that should probably be truncated, " +
"but could be also expanded so you can see it over the lines, wow," + "but could be also expanded so you can see it over the lines, wow," +
"very amazing reason, I know, right, I'm so good at writing reasons." "very amazing reason, I know, right, I'm so good at writing reasons."
@ -49,8 +49,8 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest(), aKnockRequestPresentable(),
aKnockRequest( aKnockRequestPresentable(
userId = UserId("@user:example.com"), userId = UserId("@user:example.com"),
displayName = null, displayName = null,
avatarUrl = null, avatarUrl = null,
@ -62,7 +62,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest() aKnockRequestPresentable()
) )
), ),
actionTarget = KnockRequestsActionTarget.AcceptAll, actionTarget = KnockRequestsActionTarget.AcceptAll,
@ -71,7 +71,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest() aKnockRequestPresentable()
) )
), ),
actionTarget = KnockRequestsActionTarget.AcceptAll, actionTarget = KnockRequestsActionTarget.AcceptAll,
@ -80,7 +80,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest() aKnockRequestPresentable()
) )
), ),
permissions = KnockRequestPermissions( permissions = KnockRequestPermissions(
@ -94,7 +94,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest() aKnockRequestPresentable()
) )
), ),
permissions = KnockRequestPermissions( permissions = KnockRequestPermissions(
@ -106,7 +106,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest() aKnockRequestPresentable()
) )
), ),
permissions = KnockRequestPermissions( permissions = KnockRequestPermissions(
@ -118,7 +118,7 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success( knockRequests = AsyncData.Success(
persistentListOf( persistentListOf(
aKnockRequest() aKnockRequestPresentable()
) )
), ),
permissions = KnockRequestPermissions( permissions = KnockRequestPermissions(

8
features/knockrequests/impl/src/test/kotlin/io/element/android/features/knockrequests/impl/banner/KnockRequestsBannerViewTest.kt
View file

@ -14,7 +14,7 @@ import androidx.compose.ui.test.onNodeWithContentDescription
import androidx.compose.ui.test.performClick import androidx.compose.ui.test.performClick
import androidx.test.ext.junit.runners.AndroidJUnit4 import androidx.test.ext.junit.runners.AndroidJUnit4
import io.element.android.features.knockrequests.impl.R import io.element.android.features.knockrequests.impl.R
import io.element.android.features.knockrequests.impl.data.aKnockRequest import io.element.android.features.knockrequests.impl.data.aKnockRequestPresentable
import io.element.android.libraries.ui.strings.CommonStrings import io.element.android.libraries.ui.strings.CommonStrings
import io.element.android.tests.testutils.EnsureNeverCalled import io.element.android.tests.testutils.EnsureNeverCalled
import io.element.android.tests.testutils.EventsRecorder import io.element.android.tests.testutils.EventsRecorder
@ -51,9 +51,9 @@ class KnockRequestsBannerViewTest {
rule.setKnockRequestsBannerView( rule.setKnockRequestsBannerView(
state = aKnockRequestsBannerState( state = aKnockRequestsBannerState(
knockRequests = listOf( knockRequests = listOf(
aKnockRequest(displayName = "Alice"), aKnockRequestPresentable(displayName = "Alice"),
aKnockRequest(displayName = "Bob"), aKnockRequestPresentable(displayName = "Bob"),
aKnockRequest(displayName = "Charlie") aKnockRequestPresentable(displayName = "Charlie")
), ),
eventSink = eventsRecorder, eventSink = eventsRecorder,
), ),

16
features/knockrequests/impl/src/test/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListViewTest.kt
View file

@ -12,7 +12,7 @@ import androidx.compose.ui.test.junit4.AndroidComposeTestRule
import androidx.compose.ui.test.junit4.createAndroidComposeRule import androidx.compose.ui.test.junit4.createAndroidComposeRule
import androidx.test.ext.junit.runners.AndroidJUnit4 import androidx.test.ext.junit.runners.AndroidJUnit4
import io.element.android.features.knockrequests.impl.R import io.element.android.features.knockrequests.impl.R
import io.element.android.features.knockrequests.impl.data.aKnockRequest import io.element.android.features.knockrequests.impl.data.aKnockRequestPresentable
import io.element.android.libraries.architecture.AsyncAction import io.element.android.libraries.architecture.AsyncAction
import io.element.android.libraries.architecture.AsyncData import io.element.android.libraries.architecture.AsyncData
import io.element.android.libraries.ui.strings.CommonStrings import io.element.android.libraries.ui.strings.CommonStrings
@ -48,7 +48,7 @@ class KnockRequestsListViewTest {
@Test @Test
fun `clicking on accept emit the expected event`() { fun `clicking on accept emit the expected event`() {
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>() val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
val knockRequest = aKnockRequest() val knockRequest = aKnockRequestPresentable()
rule.setKnockRequestsListView( rule.setKnockRequestsListView(
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success(persistentListOf(knockRequest)), knockRequests = AsyncData.Success(persistentListOf(knockRequest)),
@ -62,7 +62,7 @@ class KnockRequestsListViewTest {
@Test @Test
fun `clicking on decline emit the expected event`() { fun `clicking on decline emit the expected event`() {
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>() val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
val knockRequest = aKnockRequest() val knockRequest = aKnockRequestPresentable()
rule.setKnockRequestsListView( rule.setKnockRequestsListView(
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success(persistentListOf(knockRequest)), knockRequests = AsyncData.Success(persistentListOf(knockRequest)),
@ -76,7 +76,7 @@ class KnockRequestsListViewTest {
@Test @Test
fun `clicking on decline and ban emit the expected event`() { fun `clicking on decline and ban emit the expected event`() {
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>() val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
val knockRequest = aKnockRequest() val knockRequest = aKnockRequestPresentable()
rule.setKnockRequestsListView( rule.setKnockRequestsListView(
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success(persistentListOf(knockRequest)), knockRequests = AsyncData.Success(persistentListOf(knockRequest)),
@ -90,7 +90,7 @@ class KnockRequestsListViewTest {
@Test @Test
fun `clicking on accept all emit the expected event`() { fun `clicking on accept all emit the expected event`() {
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>() val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
val knockRequests = persistentListOf(aKnockRequest(), aKnockRequest()) val knockRequests = persistentListOf(aKnockRequestPresentable(), aKnockRequestPresentable())
rule.setKnockRequestsListView( rule.setKnockRequestsListView(
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success(knockRequests), knockRequests = AsyncData.Success(knockRequests),
@ -104,7 +104,7 @@ class KnockRequestsListViewTest {
@Test @Test
fun `retry on async view retry emit the expected event`() { fun `retry on async view retry emit the expected event`() {
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>() val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
val knockRequests = persistentListOf(aKnockRequest(), aKnockRequest()) val knockRequests = persistentListOf(aKnockRequestPresentable(), aKnockRequestPresentable())
rule.setKnockRequestsListView( rule.setKnockRequestsListView(
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success(knockRequests), knockRequests = AsyncData.Success(knockRequests),
@ -120,7 +120,7 @@ class KnockRequestsListViewTest {
@Test @Test
fun `canceling async view emit the expected event`() { fun `canceling async view emit the expected event`() {
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>() val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
val knockRequests = persistentListOf(aKnockRequest(), aKnockRequest()) val knockRequests = persistentListOf(aKnockRequestPresentable(), aKnockRequestPresentable())
rule.setKnockRequestsListView( rule.setKnockRequestsListView(
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success(knockRequests), knockRequests = AsyncData.Success(knockRequests),
@ -136,7 +136,7 @@ class KnockRequestsListViewTest {
@Test @Test
fun `confirming async view emit the expected event`() { fun `confirming async view emit the expected event`() {
val eventsRecorder = EventsRecorder<KnockRequestsListEvents>() val eventsRecorder = EventsRecorder<KnockRequestsListEvents>()
val knockRequests = persistentListOf(aKnockRequest(), aKnockRequest()) val knockRequests = persistentListOf(aKnockRequestPresentable(), aKnockRequestPresentable())
rule.setKnockRequestsListView( rule.setKnockRequestsListView(
aKnockRequestsListState( aKnockRequestsListState(
knockRequests = AsyncData.Success(knockRequests), knockRequests = AsyncData.Success(knockRequests),