Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Check for team membership, not org membership

Browse source
This commit is contained in:
Michael Kaye 2023-04-04 12:57:43 +01:00
parent 893c95fd77
commit 88c0306d7d
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tools/danger/dangerfile.js
View file

@ -105,19 +105,24 @@ function signoff_unneeded(reason) {
if (allowList.includes(user)) { if (allowList.includes(user)) {
signoff_unneeded("allow-list") signoff_unneeded("allow-list")
} else { } else {
github.api.rest.orgs.checkMembershipForUser({ // github.api.rest.orgs.checkMembershipForUser({
// org: "vector-im",
// username: user,
// }).then((result) => {
github.api.rest.teams.getMembershipForUserInOrg({
org: "vector-im", org: "vector-im",
team_slug: "vector-core",
username: user, username: user,
}).then((result) => { }).then((result) => {
if (result.status == 204) { if (result.status == 204 || result.status == 200) {
signoff_unneeded("org-member") signoff_unneeded("team-member")
} }
else { else {
signoff_needed("not-org-member") signoff_needed("not-team-member")
} }
}).catch((error) => { }).catch((error) => {
if (error.response.status == 404) { if (error.response.status == 404) {
signoff_needed("not-org-member"); signoff_needed("not-team-member");
} else { } else {
console.log(error); signoff_needed("error") console.log(error); signoff_needed("error")
} }