Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Fix issues detected by Paparazzi

Browse source
This commit is contained in:
Benoit Marty 2026-01-26 18:23:32 +01:00 • committed by Benoit Marty
parent 70f8ac20b6
commit 8cc2d77964
3 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/reactionsummary/ReactionSummaryView.kt
View file

@ -114,8 +114,10 @@ private fun ReactionSummaryViewContent(
LaunchedEffect(pagerState.currentPage) { LaunchedEffect(pagerState.currentPage) {
selectedReactionKey = summary.reactions[pagerState.currentPage].key selectedReactionKey = summary.reactions[pagerState.currentPage].key
val visibleInfo = reactionListState.layoutInfo.visibleItemsInfo val visibleInfo = reactionListState.layoutInfo.visibleItemsInfo
if (selectedReactionIndex <= visibleInfo.first().index || selectedReactionIndex >= visibleInfo.last().index) { if (visibleInfo.isNotEmpty()) {
reactionListState.animateScrollToItem(selectedReactionIndex) if (selectedReactionIndex <= visibleInfo.first().index || selectedReactionIndex >= visibleInfo.last().index) {
reactionListState.animateScrollToItem(selectedReactionIndex)
}
} }
} }

7
features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/developer/DeveloperSettingsStateProvider.kt
View file

@ -32,7 +32,12 @@ open class DeveloperSettingsStateProvider : PreviewParameterProvider<DeveloperSe
), ),
aDeveloperSettingsState( aDeveloperSettingsState(
isEnterpriseBuild = true, isEnterpriseBuild = true,
showColorPicker = true, // Disable the color picker for now, Paparazzi is failing with:
// java.lang.IllegalArgumentException: Cannot round NaN value.
// at kotlin.math.MathKt__MathJVMKt.roundToInt(MathJVM.kt:1210)
// at io.mhssn.colorpicker.ext.ColorExtKt.lighten(ColorExt.kt:86)
// at io.mhssn.colorpicker.pickers.ClassicColorPickerKt$ClassicColorPicker$1$1.invokeSuspend(ClassicColorPicker.kt:53)
showColorPicker = false,
), ),
) )
} }

4
libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/local/player/ExoPlayerForPreview.kt
View file

@ -142,7 +142,9 @@ class ExoPlayerForPreview(
override fun getMediaItemCount(): Int = throw NotImplementedError() override fun getMediaItemCount(): Int = throw NotImplementedError()
override fun getMediaItemAt(index: Int): MediaItem = throw NotImplementedError() override fun getMediaItemAt(index: Int): MediaItem = throw NotImplementedError()
override fun getDuration(): Long = throw NotImplementedError() override fun getDuration(): Long = throw NotImplementedError()
override fun getCurrentPosition(): Long = throw NotImplementedError()
// Cannot throw, this method is invoked when recording Paparazzi screenshots.
override fun getCurrentPosition(): Long = 0L
override fun getBufferedPosition(): Long = throw NotImplementedError() override fun getBufferedPosition(): Long = throw NotImplementedError()
override fun getBufferedPercentage(): Int = throw NotImplementedError() override fun getBufferedPercentage(): Int = throw NotImplementedError()
override fun getTotalBufferedDuration(): Long = throw NotImplementedError() override fun getTotalBufferedDuration(): Long = throw NotImplementedError()