Merge pull request #3295 from frebib/feat/big-emoji
Big emoji-only messages
This commit is contained in:
commit
8cc8f1fce1
11 changed files with 112 additions and 7 deletions
|
|
@ -72,6 +72,7 @@ dependencies {
|
||||||
implementation(libs.androidx.constraintlayout.compose)
|
implementation(libs.androidx.constraintlayout.compose)
|
||||||
implementation(libs.androidx.media3.exoplayer)
|
implementation(libs.androidx.media3.exoplayer)
|
||||||
implementation(libs.androidx.media3.ui)
|
implementation(libs.androidx.media3.ui)
|
||||||
|
implementation(libs.sigpwned.emoji4j)
|
||||||
implementation(libs.vanniktech.blurhash)
|
implementation(libs.vanniktech.blurhash)
|
||||||
implementation(libs.telephoto.zoomableimage)
|
implementation(libs.telephoto.zoomableimage)
|
||||||
implementation(libs.matrix.emojibase.bindings)
|
implementation(libs.matrix.emojibase.bindings)
|
||||||
|
|
|
||||||
|
|
@ -35,6 +35,7 @@ import io.element.android.features.messages.impl.timeline.components.layout.Cont
|
||||||
import io.element.android.features.messages.impl.timeline.components.layout.ContentAvoidingLayoutData
|
import io.element.android.features.messages.impl.timeline.components.layout.ContentAvoidingLayoutData
|
||||||
import io.element.android.features.messages.impl.timeline.model.event.TimelineItemTextBasedContent
|
import io.element.android.features.messages.impl.timeline.model.event.TimelineItemTextBasedContent
|
||||||
import io.element.android.features.messages.impl.timeline.model.event.TimelineItemTextBasedContentProvider
|
import io.element.android.features.messages.impl.timeline.model.event.TimelineItemTextBasedContentProvider
|
||||||
|
import io.element.android.features.messages.impl.utils.containsOnlyEmojis
|
||||||
import io.element.android.libraries.designsystem.preview.ElementPreview
|
import io.element.android.libraries.designsystem.preview.ElementPreview
|
||||||
import io.element.android.libraries.designsystem.preview.PreviewsDayNight
|
import io.element.android.libraries.designsystem.preview.PreviewsDayNight
|
||||||
import io.element.android.libraries.matrix.api.core.UserId
|
import io.element.android.libraries.matrix.api.core.UserId
|
||||||
|
|
@ -54,9 +55,15 @@ fun TimelineItemTextView(
|
||||||
modifier: Modifier = Modifier,
|
modifier: Modifier = Modifier,
|
||||||
onContentLayoutChange: (ContentAvoidingLayoutData) -> Unit = {},
|
onContentLayoutChange: (ContentAvoidingLayoutData) -> Unit = {},
|
||||||
) {
|
) {
|
||||||
|
val emojiOnly = (content.formattedBody == null || content.formattedBody.toString() == content.body) &&
|
||||||
|
content.body.replace(" ", "").containsOnlyEmojis()
|
||||||
|
val textStyle = when {
|
||||||
|
emojiOnly -> ElementTheme.typography.fontHeadingXlRegular
|
||||||
|
else -> ElementTheme.typography.fontBodyLgRegular
|
||||||
|
}
|
||||||
CompositionLocalProvider(
|
CompositionLocalProvider(
|
||||||
LocalContentColor provides ElementTheme.colors.textPrimary,
|
LocalContentColor provides ElementTheme.colors.textPrimary,
|
||||||
LocalTextStyle provides ElementTheme.typography.fontBodyLgRegular
|
LocalTextStyle provides textStyle
|
||||||
) {
|
) {
|
||||||
val body = getTextWithResolvedMentions(content)
|
val body = getTextWithResolvedMentions(content)
|
||||||
Box(modifier.semantics { contentDescription = content.plainText }) {
|
Box(modifier.semantics { contentDescription = content.plainText }) {
|
||||||
|
|
|
||||||
|
|
@ -38,10 +38,10 @@ fun anAggregatedReaction(
|
||||||
count: Int = 1,
|
count: Int = 1,
|
||||||
isHighlighted: Boolean = false,
|
isHighlighted: Boolean = false,
|
||||||
): AggregatedReaction {
|
): AggregatedReaction {
|
||||||
|
val timeFormatter = DateFormat.getTimeInstance(DateFormat.SHORT, java.util.Locale.US)
|
||||||
|
val date = Date(1_689_061_264L)
|
||||||
val senders = buildList {
|
val senders = buildList {
|
||||||
repeat(count) { index ->
|
repeat(count) { index ->
|
||||||
val timeFormatter = DateFormat.getTimeInstance(DateFormat.SHORT)
|
|
||||||
val date = Date(1_689_061_264L)
|
|
||||||
add(
|
add(
|
||||||
AggregatedReactionSender(
|
AggregatedReactionSender(
|
||||||
senderId = if (isHighlighted && index == 0) userId else UserId("@user$index:server.org"),
|
senderId = if (isHighlighted && index == 0) userId else UserId("@user$index:server.org"),
|
||||||
|
|
|
||||||
|
|
@ -42,6 +42,7 @@ class TimelineItemEventContentProvider : PreviewParameterProvider<TimelineItemEv
|
||||||
aTimelineItemTextContent(),
|
aTimelineItemTextContent(),
|
||||||
aTimelineItemUnknownContent(),
|
aTimelineItemUnknownContent(),
|
||||||
aTimelineItemTextContent().copy(isEdited = true),
|
aTimelineItemTextContent().copy(isEdited = true),
|
||||||
|
aTimelineItemTextContent(body = "😁")
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,44 @@
|
||||||
|
/*
|
||||||
|
* Copyright (c) 2024 New Vector Ltd
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* https://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package io.element.android.features.messages.impl.utils
|
||||||
|
|
||||||
|
import com.sigpwned.emoji4j.core.Grapheme.Type.EMOJI
|
||||||
|
import com.sigpwned.emoji4j.core.Grapheme.Type.PICTOGRAPHIC
|
||||||
|
import com.sigpwned.emoji4j.core.GraphemeMatchResult
|
||||||
|
import com.sigpwned.emoji4j.core.GraphemeMatcher
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Returns true if the string consists exclusively of "emoji or pictographic graphemes".
|
||||||
|
*/
|
||||||
|
fun String.containsOnlyEmojis(): Boolean {
|
||||||
|
if (isEmpty()) return false
|
||||||
|
|
||||||
|
val matcher = GraphemeMatcher(this)
|
||||||
|
var m: GraphemeMatchResult? = null
|
||||||
|
var contiguous = true
|
||||||
|
var previous = 0
|
||||||
|
while (contiguous && matcher.find()) {
|
||||||
|
m = matcher.toMatchResult()
|
||||||
|
// Many non-"emoji" characters are pictographics. We only want to identify this specific range
|
||||||
|
// https://en.wikipedia.org/wiki/Miscellaneous_Symbols_and_Pictographs
|
||||||
|
val isEmoji = m!!.grapheme().type == EMOJI || m.grapheme().type == PICTOGRAPHIC && m.group() in "🌍".."🗺"
|
||||||
|
contiguous = isEmoji and (m.start() == previous)
|
||||||
|
previous = m.end()
|
||||||
|
}
|
||||||
|
|
||||||
|
return contiguous and (m?.end() == length)
|
||||||
|
}
|
||||||
|
|
@ -0,0 +1,45 @@
|
||||||
|
/*
|
||||||
|
* Copyright (c) 2024 New Vector Ltd
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* https://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package io.element.android.features.messages.impl.utils
|
||||||
|
|
||||||
|
import org.junit.Assert
|
||||||
|
import org.junit.Test
|
||||||
|
|
||||||
|
class EmojiTest {
|
||||||
|
@Test
|
||||||
|
fun validEmojis() {
|
||||||
|
// Simple single/multiple single-codepoint emojis per string
|
||||||
|
Assert.assertTrue("👍".containsOnlyEmojis())
|
||||||
|
Assert.assertTrue("😀".containsOnlyEmojis())
|
||||||
|
Assert.assertTrue("🙂🙁".containsOnlyEmojis())
|
||||||
|
Assert.assertTrue("👁❤️🍝".containsOnlyEmojis()) // 👁 is a pictographic
|
||||||
|
Assert.assertTrue("👨👩👦1️⃣🚀👳🏾♂️🪩".containsOnlyEmojis())
|
||||||
|
Assert.assertTrue("🌍🌎🌏".containsOnlyEmojis())
|
||||||
|
|
||||||
|
// Awkward multi-codepoint graphemes
|
||||||
|
Assert.assertTrue("🧑🧑🧒🧒".containsOnlyEmojis())
|
||||||
|
Assert.assertTrue("🏴☠".containsOnlyEmojis())
|
||||||
|
Assert.assertTrue("👩🏿🔧".containsOnlyEmojis())
|
||||||
|
|
||||||
|
Assert.assertFalse("".containsOnlyEmojis())
|
||||||
|
Assert.assertFalse(" ".containsOnlyEmojis())
|
||||||
|
Assert.assertFalse("🙂 🙁".containsOnlyEmojis())
|
||||||
|
Assert.assertFalse(" 🙂 🙁 ".containsOnlyEmojis())
|
||||||
|
Assert.assertFalse("Hello".containsOnlyEmojis())
|
||||||
|
Assert.assertFalse("Hello 👋".containsOnlyEmojis())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
@ -192,6 +192,7 @@ matrix_analytics_events = "com.github.matrix-org:matrix-analytics-events:0.23.1"
|
||||||
|
|
||||||
# Emojibase
|
# Emojibase
|
||||||
matrix_emojibase_bindings = "io.element.android:emojibase-bindings:1.1.3"
|
matrix_emojibase_bindings = "io.element.android:emojibase-bindings:1.1.3"
|
||||||
|
sigpwned_emoji4j = "com.sigpwned:emoji4j-core:15.1.0"
|
||||||
|
|
||||||
# Di
|
# Di
|
||||||
inject = "javax.inject:javax.inject:1"
|
inject = "javax.inject:javax.inject:1"
|
||||||
|
|
|
||||||
|
|
@ -1,3 +1,3 @@
|
||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:9490990c863318390d0f088ff82ad01a688c81cada63d749872b22b633fa12fe
|
oid sha256:65eb29b745fabe2587019c169a48a862b129a3ece30cf9bc82aff09c67878b35
|
||||||
size 23040
|
size 23180
|
||||||
|
|
|
||||||
|
|
@ -1,3 +1,3 @@
|
||||||
version https://git-lfs.github.com/spec/v1
|
version https://git-lfs.github.com/spec/v1
|
||||||
oid sha256:730c2c5ab52209366611546dbdbbed62214f6f5e13328be66cce5f08d8f4f0e5
|
oid sha256:c1cf0091d377d8018d14804433aaa67d1b0b510778b6f8a4e8a73faff2b4c782
|
||||||
size 23125
|
size 23280
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,3 @@
|
||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:f6378c00fdec9f1d7e98835e8c894c33b4d2d14508df4d36107c9c74d05e8dc3
|
||||||
|
size 63866
|
||||||
|
|
@ -0,0 +1,3 @@
|
||||||
|
version https://git-lfs.github.com/spec/v1
|
||||||
|
oid sha256:1536adcfba0421171f830d49751af7d5d9b39672cdb43b9ad1421e949515cbe8
|
||||||
|
size 63888
|
||||||
Loading…
Add table
Add a link
Reference in a new issue