Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 9 Projects Releases Packages Wiki Activity Actions

Try fixing 'Timeline Event object has already been destroyed' (#5675)

Browse source 
This will display a fallback notification. I don't see how the current code could cause it, but I tried to re-structure it a bit so we don't have nested `use` usages and `timestamp` is fetched ahead of time.
This commit is contained in:
Jorge Martin Espinosa 2025-11-04 11:36:17 +01:00 • committed by GitHub
parent a1e270578a
commit 8d529849e8
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/notification/NotificationMapper.kt
View file

@ -39,6 +39,7 @@ class NotificationMapper(
isDirect = item.roomInfo.isDirect, isDirect = item.roomInfo.isDirect,
activeMembersCount = item.roomInfo.joinedMembersCount.toInt(), activeMembersCount = item.roomInfo.joinedMembersCount.toInt(),
) )
val timestamp = item.timestamp() ?: clock.epochMillis()
NotificationData( NotificationData(
sessionId = sessionId, sessionId = sessionId,
eventId = eventId, eventId = eventId,
@ -53,8 +54,8 @@ class NotificationMapper(
isDm = isDm, isDm = isDm,
isEncrypted = item.roomInfo.isEncrypted.orFalse(), isEncrypted = item.roomInfo.isEncrypted.orFalse(),
isNoisy = item.isNoisy.orFalse(), isNoisy = item.isNoisy.orFalse(),
timestamp = item.timestamp() ?: clock.epochMillis(), timestamp = timestamp,
content = item.event.use { notificationContentMapper.map(it) }.getOrThrow(), content = notificationContentMapper.map(item.event).getOrThrow(),
hasMention = item.hasMention.orFalse(), hasMention = item.hasMention.orFalse(),
) )
} }

3
libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/notification/TimelineEventToNotificationContentMapper.kt
View file

@ -25,8 +25,9 @@ class TimelineEventToNotificationContentMapper {
fun map(timelineEvent: TimelineEvent): Result<NotificationContent> { fun map(timelineEvent: TimelineEvent): Result<NotificationContent> {
return runCatchingExceptions { return runCatchingExceptions {
timelineEvent.use { timelineEvent.use {
val senderId = UserId(timelineEvent.senderId())
timelineEvent.eventType().use { eventType -> timelineEvent.eventType().use { eventType ->
eventType.toContent(senderId = UserId(timelineEvent.senderId())) eventType.toContent(senderId = senderId)
} }
} }
} }