Create VoiceMessageConfig in appconfig module.
This commit is contained in:
parent
9746df6797
commit
8d8dcb68aa
4 changed files with 30 additions and 4 deletions
|
|
@ -0,0 +1,23 @@
|
||||||
|
/*
|
||||||
|
* Copyright (c) 2023 New Vector Ltd
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package io.element.android.appconfig
|
||||||
|
|
||||||
|
import kotlin.time.Duration.Companion.minutes
|
||||||
|
|
||||||
|
object VoiceMessageConfig {
|
||||||
|
val maxVoiceMessageDuration = 30.minutes
|
||||||
|
}
|
||||||
|
|
@ -31,6 +31,7 @@ dependencies {
|
||||||
api(libs.opusencoder)
|
api(libs.opusencoder)
|
||||||
|
|
||||||
implementation(libs.dagger)
|
implementation(libs.dagger)
|
||||||
|
implementation(projects.appconfig)
|
||||||
implementation(projects.libraries.matrix.api)
|
implementation(projects.libraries.matrix.api)
|
||||||
implementation(projects.libraries.core)
|
implementation(projects.libraries.core)
|
||||||
implementation(projects.libraries.di)
|
implementation(projects.libraries.di)
|
||||||
|
|
|
||||||
|
|
@ -19,6 +19,7 @@ package io.element.android.libraries.voicerecorder.impl
|
||||||
import android.Manifest
|
import android.Manifest
|
||||||
import androidx.annotation.RequiresPermission
|
import androidx.annotation.RequiresPermission
|
||||||
import com.squareup.anvil.annotations.ContributesBinding
|
import com.squareup.anvil.annotations.ContributesBinding
|
||||||
|
import io.element.android.appconfig.VoiceMessageConfig
|
||||||
import io.element.android.libraries.core.coroutine.CoroutineDispatchers
|
import io.element.android.libraries.core.coroutine.CoroutineDispatchers
|
||||||
import io.element.android.libraries.core.coroutine.childScope
|
import io.element.android.libraries.core.coroutine.childScope
|
||||||
import io.element.android.libraries.di.RoomScope
|
import io.element.android.libraries.di.RoomScope
|
||||||
|
|
@ -94,7 +95,7 @@ class VoiceRecorderImpl @Inject constructor(
|
||||||
|
|
||||||
val elapsedTime = startedAt.elapsedNow()
|
val elapsedTime = startedAt.elapsedNow()
|
||||||
|
|
||||||
if (elapsedTime > 30.minutes) {
|
if (elapsedTime > VoiceMessageConfig.maxVoiceMessageDuration) {
|
||||||
Timber.w("Voice message time limit reached")
|
Timber.w("Voice message time limit reached")
|
||||||
stopRecord(false)
|
stopRecord(false)
|
||||||
return@record
|
return@record
|
||||||
|
|
|
||||||
|
|
@ -20,6 +20,7 @@ import android.media.AudioFormat
|
||||||
import android.media.MediaRecorder
|
import android.media.MediaRecorder
|
||||||
import app.cash.turbine.test
|
import app.cash.turbine.test
|
||||||
import com.google.common.truth.Truth.assertThat
|
import com.google.common.truth.Truth.assertThat
|
||||||
|
import io.element.android.appconfig.VoiceMessageConfig
|
||||||
import io.element.android.libraries.voicerecorder.api.VoiceRecorderState
|
import io.element.android.libraries.voicerecorder.api.VoiceRecorderState
|
||||||
import io.element.android.libraries.voicerecorder.impl.audio.Audio
|
import io.element.android.libraries.voicerecorder.impl.audio.Audio
|
||||||
import io.element.android.libraries.voicerecorder.impl.audio.AudioConfig
|
import io.element.android.libraries.voicerecorder.impl.audio.AudioConfig
|
||||||
|
|
@ -77,8 +78,8 @@ class VoiceRecorderImplTest {
|
||||||
|
|
||||||
voiceRecorder.startRecord()
|
voiceRecorder.startRecord()
|
||||||
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Recording(0.minutes, listOf(1.0f)))
|
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Recording(0.minutes, listOf(1.0f)))
|
||||||
timeSource += 30.minutes
|
timeSource += VoiceMessageConfig.maxVoiceMessageDuration
|
||||||
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Recording(30.minutes, listOf()))
|
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Recording(VoiceMessageConfig.maxVoiceMessageDuration, listOf()))
|
||||||
timeSource += 1.milliseconds
|
timeSource += 1.milliseconds
|
||||||
|
|
||||||
assertThat(awaitItem()).isEqualTo(
|
assertThat(awaitItem()).isEqualTo(
|
||||||
|
|
@ -86,7 +87,7 @@ class VoiceRecorderImplTest {
|
||||||
file = File(FILE_PATH),
|
file = File(FILE_PATH),
|
||||||
mimeType = "audio/ogg",
|
mimeType = "audio/ogg",
|
||||||
waveform = List(100) { 1f },
|
waveform = List(100) { 1f },
|
||||||
duration = 30.minutes,
|
duration = VoiceMessageConfig.maxVoiceMessageDuration,
|
||||||
)
|
)
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue