Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Remove Knock FF check to show the Security and Privacy entry point.

Browse source
This commit is contained in:
Benoit Marty 2025-10-17 16:56:57 +02:00 • committed by Benoit Marty
parent 3140de4577
commit 8ffae8d416
2 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsPresenter.kt
View file

@ -164,7 +164,7 @@ class RoomDetailsPresenter(
val securityAndPrivacyPermissions = room.securityAndPrivacyPermissionsAsState(syncUpdateFlow.value) val securityAndPrivacyPermissions = room.securityAndPrivacyPermissionsAsState(syncUpdateFlow.value)
val canShowSecurityAndPrivacy by remember { val canShowSecurityAndPrivacy by remember {
derivedStateOf { derivedStateOf {
isKnockRequestsEnabled && roomType is RoomDetailsType.Room && securityAndPrivacyPermissions.value.hasAny roomType is RoomDetailsType.Room && securityAndPrivacyPermissions.value.hasAny
} }
} }

4
features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsPresenterTest.kt
View file

@ -719,10 +719,6 @@ class RoomDetailsPresenterTest {
val presenter = createRoomDetailsPresenter(room = room, featureFlagService = featureFlagService) val presenter = createRoomDetailsPresenter(room = room, featureFlagService = featureFlagService)
presenter.testWithLifecycleOwner(lifecycleOwner = fakeLifecycleOwner) { presenter.testWithLifecycleOwner(lifecycleOwner = fakeLifecycleOwner) {
skipItems(1) skipItems(1)
with(awaitItem()) {
assertThat(canShowSecurityAndPrivacy).isFalse()
}
featureFlagService.setFeatureEnabled(FeatureFlags.Knock, true)
with(awaitItem()) { with(awaitItem()) {
assertThat(canShowSecurityAndPrivacy).isTrue() assertThat(canShowSecurityAndPrivacy).isTrue()
} }