From 900074ee20f36d61568d61bfb08a94df560b08ec Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 24 Sep 2024 16:37:32 +0200 Subject: [PATCH] `flatMap` with `runCatching` is more appropriate here. --- .../impl/voicemessages/timeline/VoiceMessagePresenter.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/VoiceMessagePresenter.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/VoiceMessagePresenter.kt index a288309422..3ab00a71bc 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/VoiceMessagePresenter.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/VoiceMessagePresenter.kt @@ -27,6 +27,7 @@ import io.element.android.features.messages.impl.voicemessages.VoiceMessageExcep import io.element.android.libraries.architecture.AsyncData import io.element.android.libraries.architecture.Presenter import io.element.android.libraries.architecture.runUpdatingState +import io.element.android.libraries.core.extensions.flatMap import io.element.android.libraries.di.RoomScope import io.element.android.libraries.ui.utils.time.formatShort import io.element.android.services.analytics.api.AnalyticsService @@ -126,8 +127,8 @@ class VoiceMessagePresenter @AssistedInject constructor( it }, ) { - player.prepare().apply { - player.play() + player.prepare().flatMap { + runCatching { player.play() } } } }