Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Add missing test.

Browse source
This commit is contained in:
Benoit Marty 2025-10-23 09:59:24 +02:00
parent 9983871db7
commit 937519639d
2 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/json/JsonProvider.kt
View file

@ -17,7 +17,7 @@ import kotlinx.serialization.json.Json
/** /**
* Provides a Json instance configured to ignore unknown keys. * Provides a Json instance configured to ignore unknown keys.
*/ */
interface JsonProvider : Provider<Json> fun interface JsonProvider : Provider<Json>
@ContributesBinding(AppScope::class) @ContributesBinding(AppScope::class)
@SingleIn(AppScope::class) @SingleIn(AppScope::class)

14
libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/workmanager/SyncNotificationWorkManagerRequestTest.kt
View file

@ -49,14 +49,24 @@ class SyncNotificationWorkManagerRequestTest {
assertThat(result.isFailure).isTrue() assertThat(result.isFailure).isTrue()
} }
// TODO add test for invalid serialization (how?) @Test
fun `build - invalid serialization`() = runTest {
val request = createSyncNotificationWorkManagerRequest(
sessionId = A_SESSION_ID,
notificationEventRequests = listOf(aNotificationEventRequest()),
workerDataConverter = WorkerDataConverter({ error("error during serialization") })
)
val result = request.build()
assertThat(result.isFailure).isTrue()
}
} }
private fun createSyncNotificationWorkManagerRequest( private fun createSyncNotificationWorkManagerRequest(
sessionId: SessionId, sessionId: SessionId,
notificationEventRequests: List<NotificationEventRequest>, notificationEventRequests: List<NotificationEventRequest>,
workerDataConverter: WorkerDataConverter = WorkerDataConverter(DefaultJsonProvider())
) = SyncNotificationWorkManagerRequest( ) = SyncNotificationWorkManagerRequest(
sessionId = sessionId, sessionId = sessionId,
notificationEventRequests = notificationEventRequests, notificationEventRequests = notificationEventRequests,
workerDataConverter = WorkerDataConverter(DefaultJsonProvider()), workerDataConverter = workerDataConverter,
) )