Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

[a11y] Improve accessibility of screen headers.

Browse source
This commit is contained in:
Benoit Marty 2026-05-20 15:49:18 +02:00
parent c5911d7849
commit 97ca702bc8
2 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerView.kt
View file

@ -55,6 +55,8 @@ import androidx.compose.ui.layout.onVisibilityChanged
import androidx.compose.ui.platform.LocalDensity import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.platform.LocalInspectionMode import androidx.compose.ui.platform.LocalInspectionMode
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.clearAndSetSemantics
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.heading import androidx.compose.ui.semantics.heading
import androidx.compose.ui.semantics.semantics import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.style.TextOverflow import androidx.compose.ui.text.style.TextOverflow
@ -495,14 +497,20 @@ private fun MediaViewerTopBar(
TopAppBar( TopAppBar(
title = { title = {
if (senderName != null && dateSent != null) { if (senderName != null && dateSent != null) {
val description = stringResource(
CommonStrings.a11y_sent_by_sender_at_date,
senderName,
dateSent,
)
Column( Column(
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.clearAndSetSemantics {
heading()
contentDescription = description
},
) { ) {
Text( Text(
modifier = Modifier.semantics {
heading()
},
text = senderName, text = senderName,
style = ElementTheme.typography.fontBodyMdMedium, style = ElementTheme.typography.fontBodyMdMedium,
color = ElementTheme.colors.textPrimary, color = ElementTheme.colors.textPrimary,

1
libraries/ui-strings/src/main/res/values/localazy.xml
View file

@ -48,6 +48,7 @@
<string name="a11y_room_avatar">"Room avatar"</string> <string name="a11y_room_avatar">"Room avatar"</string>
<string name="a11y_send_files">"Send files"</string> <string name="a11y_send_files">"Send files"</string>
<string name="a11y_sender_location">"Sender location"</string> <string name="a11y_sender_location">"Sender location"</string>
<string name="a11y_sent_by_sender_at_date">"Sent by %1$s at %2$s"</string>
<string name="a11y_session_verification_time_limited_action_required">"Time limited action required, you have one minute to verify"</string> <string name="a11y_session_verification_time_limited_action_required">"Time limited action required, you have one minute to verify"</string>
<string name="a11y_settings_with_required_action">"Settings, action required"</string> <string name="a11y_settings_with_required_action">"Settings, action required"</string>
<string name="a11y_show_password">"Show password"</string> <string name="a11y_show_password">"Show password"</string>