Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Composable functions that return a value should start with a lowercase letter

Browse source
This commit is contained in:
Benoit Marty 2023-09-05 14:21:14 +02:00 • committed by Benoit Marty
parent f9c26e19c8
commit 9e1c8279b2
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/TimelineItemEventRow.kt
View file

@ -75,7 +75,7 @@ import io.element.android.features.messages.impl.timeline.model.event.TimelineIt
import io.element.android.features.messages.impl.timeline.model.event.aTimelineItemImageContent import io.element.android.features.messages.impl.timeline.model.event.aTimelineItemImageContent
import io.element.android.features.messages.impl.timeline.model.event.aTimelineItemPollContent import io.element.android.features.messages.impl.timeline.model.event.aTimelineItemPollContent
import io.element.android.features.messages.impl.timeline.model.event.aTimelineItemTextContent import io.element.android.features.messages.impl.timeline.model.event.aTimelineItemTextContent
import io.element.android.libraries.designsystem.colors.AvatarColors import io.element.android.libraries.designsystem.colors.avatarColors
import io.element.android.libraries.designsystem.components.EqualWidthColumn import io.element.android.libraries.designsystem.components.EqualWidthColumn
import io.element.android.libraries.designsystem.components.avatar.Avatar import io.element.android.libraries.designsystem.components.avatar.Avatar
import io.element.android.libraries.designsystem.components.avatar.AvatarData import io.element.android.libraries.designsystem.components.avatar.AvatarData
@ -328,7 +328,7 @@ private fun MessageSenderInformation(
) { ) {
val avatarStrokeColor = MaterialTheme.colorScheme.background val avatarStrokeColor = MaterialTheme.colorScheme.background
val avatarSize = senderAvatar.size.dp val avatarSize = senderAvatar.size.dp
val avatarColors = AvatarColors(senderAvatar.id) val avatarColors = avatarColors(senderAvatar.id)
Box( Box(
modifier = modifier modifier = modifier
) { ) {

2
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/colors/AvatarColors.kt
View file

@ -28,7 +28,7 @@ data class AvatarColors(
) )
@Composable @Composable
fun AvatarColors(userId: String): AvatarColors { fun avatarColors(userId: String): AvatarColors {
val hash = userId.toHash() val hash = userId.toHash()
val colors = if (ElementTheme.isLightTheme) { val colors = if (ElementTheme.isLightTheme) {
avatarColorsLight[hash] avatarColorsLight[hash]

4
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/avatar/UserAvatarPreview.kt
View file

@ -24,7 +24,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import io.element.android.libraries.designsystem.colors.AvatarColors import io.element.android.libraries.designsystem.colors.avatarColors
import io.element.android.libraries.designsystem.preview.DayNightPreviews import io.element.android.libraries.designsystem.preview.DayNightPreviews
import io.element.android.libraries.designsystem.preview.ElementPreview import io.element.android.libraries.designsystem.preview.ElementPreview
import io.element.android.libraries.designsystem.theme.components.Text import io.element.android.libraries.designsystem.theme.components.Text
@ -43,7 +43,7 @@ internal fun UserAvatarPreview() = ElementPreview {
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
) { ) {
// Note: it's OK, since the hash of "0" is 0, the hash of "1" is 1, etc. // Note: it's OK, since the hash of "0" is 0, the hash of "1" is 1, etc.
Avatar(anAvatarData(), avatarColors = AvatarColors("$it")) Avatar(anAvatarData(), avatarColors = avatarColors("$it"))
Text(text = "Color index $it") Text(text = "Color index $it")
} }
} }