Enforce lambda parameters to be passed in.

This commit is contained in:
Benoit Marty 2023-06-09 17:43:34 +02:00
parent dc064069ba
commit 9fbc918f10
4 changed files with 26 additions and 14 deletions

View file

@ -31,9 +31,9 @@ import io.element.android.libraries.designsystem.preview.ElementPreviewLight
@Composable @Composable
fun ChangeServerView( fun ChangeServerView(
state: ChangeServerState, state: ChangeServerState,
onLearnMoreClicked: () -> Unit,
onDone: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
onLearnMoreClicked: () -> Unit = {},
onDone: () -> Unit = {},
) { ) {
val eventSink = state.eventSink val eventSink = state.eventSink
when (state.changeServerAction) { when (state.changeServerAction) {
@ -80,5 +80,7 @@ fun ChangeServerViewDarkPreview(@PreviewParameter(ChangeServerStateProvider::cla
private fun ContentToPreview(state: ChangeServerState) { private fun ContentToPreview(state: ChangeServerState) {
ChangeServerView( ChangeServerView(
state = state, state = state,
onLearnMoreClicked = {},
onDone = {},
) )
} }

View file

@ -57,11 +57,11 @@ import io.element.android.libraries.designsystem.theme.components.TopAppBar
@Composable @Composable
fun ChangeAccountProviderView( fun ChangeAccountProviderView(
state: ChangeAccountProviderState, state: ChangeAccountProviderState,
onBackPressed: () -> Unit,
onLearnMoreClicked: () -> Unit,
onDone: () -> Unit,
onOtherProviderClicked: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
onBackPressed: () -> Unit = {},
onLearnMoreClicked: () -> Unit = {},
onDone: () -> Unit = {},
onOtherProviderClicked: () -> Unit = {},
) { ) {
val scrollState = rememberScrollState() val scrollState = rememberScrollState()
@ -143,6 +143,9 @@ fun ChangeAccountProviderViewDarkPreview(@PreviewParameter(ChangeAccountProvider
private fun ContentToPreview(state: ChangeAccountProviderState) { private fun ContentToPreview(state: ChangeAccountProviderState) {
ChangeAccountProviderView( ChangeAccountProviderView(
state = state, state = state,
onBackPressed = { } onBackPressed = { },
onLearnMoreClicked = { },
onDone = { },
onOtherProviderClicked = { },
) )
} }

View file

@ -49,11 +49,11 @@ import io.element.android.libraries.testtags.testTag
@Composable @Composable
fun ConfirmAccountProviderView( fun ConfirmAccountProviderView(
state: ConfirmAccountProviderState, state: ConfirmAccountProviderState,
onOidcDetails: (OidcDetails) -> Unit,
onLoginPasswordNeeded: () -> Unit,
onLearnMoreClicked: () -> Unit,
onChange: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
onOidcDetails: (OidcDetails) -> Unit = {},
onLoginPasswordNeeded: () -> Unit = {},
onLearnMoreClicked: () -> Unit = {},
onChange: () -> Unit = {},
) { ) {
val isLoading by remember(state.loginFlow) { val isLoading by remember(state.loginFlow) {
derivedStateOf { derivedStateOf {
@ -158,5 +158,9 @@ fun ConfirmAccountProviderViewDarkPreview(@PreviewParameter(ConfirmAccountProvid
private fun ContentToPreview(state: ConfirmAccountProviderState) { private fun ContentToPreview(state: ConfirmAccountProviderState) {
ConfirmAccountProviderView( ConfirmAccountProviderView(
state = state, state = state,
onOidcDetails = {},
onLoginPasswordNeeded = {},
onLearnMoreClicked = {},
onChange = {},
) )
} }

View file

@ -75,10 +75,10 @@ import io.element.android.libraries.testtags.testTag
@Composable @Composable
fun SearchAccountProviderView( fun SearchAccountProviderView(
state: SearchAccountProviderState, state: SearchAccountProviderState,
onBackPressed: () -> Unit,
onLearnMoreClicked: () -> Unit,
onDone: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
onBackPressed: () -> Unit = {},
onLearnMoreClicked: () -> Unit = {},
onDone: () -> Unit = {},
) { ) {
val eventSink = state.eventSink val eventSink = state.eventSink
val scrollState = rememberScrollState() val scrollState = rememberScrollState()
@ -215,5 +215,8 @@ fun SearchAccountProviderViewDarkPreview(@PreviewParameter(SearchAccountProvider
private fun ContentToPreview(state: SearchAccountProviderState) { private fun ContentToPreview(state: SearchAccountProviderState) {
SearchAccountProviderView( SearchAccountProviderView(
state = state, state = state,
onBackPressed = {},
onLearnMoreClicked = {},
onDone = {},
) )
} }