Remember flows (#4533)

* Add Konsist test to ensure that the result of a function returning a flow is remembered.

* Remember flows before they are collected by state.

* Fix compilation issue

* Make isOnline a val.

* Make selectedUsers() a val.

* Make flow() a val.

* Make getUserConsent(), didAskUserConsent() and getAnalyticsId() some val.

* Remove Timeline.paginationStatus() and replace by direct access to the underlined flow.

* Simplify test

* userConsentFlow must be initialized before because it's used in observeUserConsent

* Fix test compilation

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsPresenter.kt

@@ -29,19 +29,18 @@ class AdvancedSettingsPresenter @Inject constructor(
     @Composable
     override fun present(): AdvancedSettingsState {
         val localCoroutineScope = rememberCoroutineScope()
-        val isDeveloperModeEnabled by appPreferencesStore
-            .isDeveloperModeEnabledFlow()
-            .collectAsState(initial = false)
-        val isSharePresenceEnabled by sessionPreferencesStore
-            .isSharePresenceEnabled()
-            .collectAsState(initial = true)
-        val doesCompressMedia by sessionPreferencesStore
-            .doesCompressMedia()
-            .collectAsState(initial = true)
+        val isDeveloperModeEnabled by remember {
+            appPreferencesStore.isDeveloperModeEnabledFlow()
+        }.collectAsState(initial = false)
+        val isSharePresenceEnabled by remember {
+            sessionPreferencesStore.isSharePresenceEnabled()
+        }.collectAsState(initial = true)
+        val doesCompressMedia by remember {
+            sessionPreferencesStore.doesCompressMedia()
+        }.collectAsState(initial = true)
         val theme by remember {
             appPreferencesStore.getThemeFlow().mapToTheme()
-        }
-            .collectAsState(initial = Theme.System)
+        }.collectAsState(initial = Theme.System)
         var showChangeThemeDialog by remember { mutableStateOf(false) }
 
         fun handleEvents(event: AdvancedSettingsEvents) {

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/blockedusers/BlockedUsersPresenter.kt

@@ -44,17 +44,17 @@ class BlockedUsersPresenter @Inject constructor(
             mutableStateOf(AsyncAction.Uninitialized)
         }
 
-        val renderBlockedUsersDetail = featureFlagService
-            .isFeatureEnabledFlow(FeatureFlags.ShowBlockedUsersDetails)
-            .collectAsState(initial = false)
+        val renderBlockedUsersDetail by remember {
+            featureFlagService.isFeatureEnabledFlow(FeatureFlags.ShowBlockedUsersDetails)
+        }.collectAsState(initial = false)
         val ignoredUserIds by matrixClient.ignoredUsersFlow.collectAsState()
         val ignoredMatrixUser by produceState(
             initialValue = ignoredUserIds.map { MatrixUser(userId = it) },
-            key1 = renderBlockedUsersDetail.value,
+            key1 = renderBlockedUsersDetail,
             key2 = ignoredUserIds
         ) {
             value = ignoredUserIds.map {
-                if (renderBlockedUsersDetail.value) {
+                if (renderBlockedUsersDetail) {
                     matrixClient.getProfile(it).getOrNull()
                 } else {
                     null

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/developer/DeveloperSettingsPresenter.kt

@@ -71,12 +71,14 @@ class DeveloperSettingsPresenter @Inject constructor(
         val clearCacheAction = remember {
             mutableStateOf<AsyncAction<Unit>>(AsyncAction.Uninitialized)
         }
-        val customElementCallBaseUrl by appPreferencesStore
-            .getCustomElementCallBaseUrlFlow()
-            .collectAsState(initial = null)
-        val hideImagesAndVideos by appPreferencesStore
-            .doesHideImagesAndVideosFlow()
-            .collectAsState(initial = false)
+        val customElementCallBaseUrl by remember {
+            appPreferencesStore
+                .getCustomElementCallBaseUrlFlow()
+        }.collectAsState(initial = null)
+        val hideImagesAndVideos by remember {
+            appPreferencesStore
+                .doesHideImagesAndVideosFlow()
+        }.collectAsState(initial = false)
 
         val tracingLogLevelFlow = remember {
             appPreferencesStore.getTracingLogLevelFlow().map { AsyncData.Success(it.toLogLevelItem()) }

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/NotificationSettingsPresenter.kt

@@ -58,9 +58,9 @@ class NotificationSettingsPresenter @Inject constructor(
         val changeNotificationSettingAction: MutableState<AsyncAction<Unit>> = remember { mutableStateOf(AsyncAction.Uninitialized) }
 
         val localCoroutineScope = rememberCoroutineScope()
-        val appNotificationsEnabled = userPushStore
-            .getNotificationEnabledForDevice()
-            .collectAsState(initial = false)
+        val appNotificationsEnabled by remember {
+            userPushStore.getNotificationEnabledForDevice()
+        }.collectAsState(initial = false)
 
         val matrixSettings: MutableState<NotificationSettingsState.MatrixSettings> = remember {
             mutableStateOf(NotificationSettingsState.MatrixSettings.Uninitialized)
@@ -158,7 +158,7 @@ class NotificationSettingsPresenter @Inject constructor(
             matrixSettings = matrixSettings.value,
             appSettings = NotificationSettingsState.AppSettings(
                 systemNotificationsEnabled = systemNotificationsEnabled.value,
-                appNotificationsEnabled = appNotificationsEnabled.value
+                appNotificationsEnabled = appNotificationsEnabled,
             ),
             changeNotificationSettingAction = changeNotificationSettingAction.value,
             currentPushDistributor = currentDistributor,