Remember flows (#4533)

* Add Konsist test to ensure that the result of a function returning a flow is remembered.

* Remember flows before they are collected by state.

* Fix compilation issue

* Make isOnline a val.

* Make selectedUsers() a val.

* Make flow() a val.

* Make getUserConsent(), didAskUserConsent() and getAnalyticsId() some val.

* Remove Timeline.paginationStatus() and replace by direct access to the underlined flow.

* Simplify test

* userConsentFlow must be initialized before because it's used in observeUserConsent

* Fix test compilation

features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/bugreport/BugReportPresenter.kt

@@ -64,9 +64,9 @@ class BugReportPresenter @Inject constructor(
                 screenshotHolder.getFileUri()
             )
         }
-        val crashInfo: String by crashDataStore
-            .crashInfo()
-            .collectAsState(initial = "")
+        val crashInfo: String by remember {
+            crashDataStore.crashInfo()
+        }.collectAsState(initial = "")
 
         val sendingProgress = remember {
             mutableFloatStateOf(0f)

features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/preferences/DefaultRageshakePreferencesPresenter.kt

@@ -10,6 +10,7 @@ package io.element.android.features.rageshake.impl.preferences
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.MutableState
 import androidx.compose.runtime.collectAsState
+import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.runtime.rememberCoroutineScope
@@ -39,13 +40,13 @@ class DefaultRageshakePreferencesPresenter @Inject constructor(
             mutableStateOf(rageshake.isAvailable())
         }
         val isFeatureAvailable = remember { rageshakeFeatureAvailability.isAvailable() }
-        val isEnabled = rageshakeDataStore
-            .isEnabled()
-            .collectAsState(initial = false)
+        val isEnabled by remember {
+            rageshakeDataStore.isEnabled()
+        }.collectAsState(initial = false)
 
-        val sensitivity = rageshakeDataStore
-            .sensitivity()
-            .collectAsState(initial = 0f)
+        val sensitivity by remember {
+            rageshakeDataStore.sensitivity()
+        }.collectAsState(initial = 0f)
 
         fun handleEvents(event: RageshakePreferencesEvents) {
             when (event) {
@@ -56,9 +57,9 @@ class DefaultRageshakePreferencesPresenter @Inject constructor(
 
         return RageshakePreferencesState(
             isFeatureEnabled = isFeatureAvailable,
-            isEnabled = isEnabled.value,
+            isEnabled = isEnabled,
             isSupported = isSupported.value,
-            sensitivity = sensitivity.value,
+            sensitivity = sensitivity,
             eventSink = ::handleEvents
         )
     }