Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Use LifecycleOwner instead of explicit Node on presenterConnector

Browse source
This commit is contained in:
ganfra 2023-01-05 10:59:26 +01:00
parent eeebb99292
commit a37cf3adde
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
features/roomlist/src/main/java/io/element/android/x/features/roomlist/RoomListNode.kt
View file

@ -31,7 +31,7 @@ class RoomListNode @AssistedInject constructor(
fun onRoomClicked(roomId: RoomId) fun onRoomClicked(roomId: RoomId)
} }
private val connector = presenterConnector(presenter) private val connector by presenterConnector(presenter)
private fun updateFilter(filter: String) { private fun updateFilter(filter: String) {
connector.emitEvent(RoomListEvents.UpdateFilter(filter)) connector.emitEvent(RoomListEvents.UpdateFilter(filter))

10
libraries/architecture/src/main/java/io/element/android/x/architecture/NodePresenterConnector.kt → libraries/architecture/src/main/java/io/element/android/x/architecture/LifecyclePresenterConnector.kt
View file

@ -1,21 +1,21 @@
package io.element.android.x.architecture package io.element.android.x.architecture
import androidx.lifecycle.LifecycleOwner
import androidx.lifecycle.lifecycleScope import androidx.lifecycle.lifecycleScope
import app.cash.molecule.AndroidUiDispatcher import app.cash.molecule.AndroidUiDispatcher
import app.cash.molecule.RecompositionClock import app.cash.molecule.RecompositionClock
import app.cash.molecule.launchMolecule import app.cash.molecule.launchMolecule
import com.bumble.appyx.core.node.Node
import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.flow.MutableSharedFlow import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.StateFlow import kotlinx.coroutines.flow.StateFlow
inline fun <reified State, reified Event> Node.presenterConnector(presenter: Presenter<State, Event>): NodePresenterConnector<State, Event> { inline fun <reified State, reified Event> LifecycleOwner.presenterConnector(presenter: Presenter<State, Event>): Lazy<LifecyclePresenterConnector<State, Event>> = lazy {
return NodePresenterConnector(node = this, presenter = presenter) LifecyclePresenterConnector(lifecycleOwner = this, presenter = presenter)
} }
class NodePresenterConnector<State, Event>(private val node: Node, presenter: Presenter<State, Event>) { class LifecyclePresenterConnector<State, Event>(lifecycleOwner: LifecycleOwner, presenter: Presenter<State, Event>) {
private val moleculeScope = CoroutineScope(node.lifecycleScope.coroutineContext + AndroidUiDispatcher.Main) private val moleculeScope = CoroutineScope(lifecycleOwner.lifecycleScope.coroutineContext + AndroidUiDispatcher.Main)
private val eventFlow: MutableSharedFlow<Event> = MutableSharedFlow(extraBufferCapacity = 64) private val eventFlow: MutableSharedFlow<Event> = MutableSharedFlow(extraBufferCapacity = 64)
val stateFlow: StateFlow<State> = moleculeScope.launchMolecule(RecompositionClock.ContextClock) { val stateFlow: StateFlow<State> = moleculeScope.launchMolecule(RecompositionClock.ContextClock) {