Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

No need to keep the Job instance.

Browse source
This commit is contained in:
Benoit Marty 2024-11-26 15:07:22 +01:00
parent 5f27c7107a
commit a698c7673c
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/attachments/preview/AttachmentsPreviewPresenter.kt
View file

@ -74,9 +74,8 @@ class AttachmentsPreviewPresenter @AssistedInject constructor(
val userSentAttachment = remember { mutableStateOf(false) } val userSentAttachment = remember { mutableStateOf(false) }
val mediaUploadInfoState = remember { mutableStateOf<AsyncData<MediaUploadInfo>>(AsyncData.Uninitialized) } val mediaUploadInfoState = remember { mutableStateOf<AsyncData<MediaUploadInfo>>(AsyncData.Uninitialized) }
var prePropressingJob: Job? = null
LaunchedEffect(Unit) { LaunchedEffect(Unit) {
prePropressingJob = preProcessAttachment( preProcessAttachment(
attachment, attachment,
mediaUploadInfoState, mediaUploadInfoState,
) )
@ -116,7 +115,6 @@ class AttachmentsPreviewPresenter @AssistedInject constructor(
AttachmentsPreviewEvents.Cancel -> { AttachmentsPreviewEvents.Cancel -> {
coroutineScope.cancel( coroutineScope.cancel(
attachment, attachment,
prePropressingJob,
mediaUploadInfoState.value, mediaUploadInfoState.value,
sendActionState, sendActionState,
) )
@ -178,7 +176,6 @@ class AttachmentsPreviewPresenter @AssistedInject constructor(
private fun CoroutineScope.cancel( private fun CoroutineScope.cancel(
attachment: Attachment, attachment: Attachment,
preProcessingJob: Job?,
mediaUploadInfo: AsyncData<MediaUploadInfo>, mediaUploadInfo: AsyncData<MediaUploadInfo>,
sendActionState: MutableState<SendActionState>, sendActionState: MutableState<SendActionState>,
) = launch { ) = launch {
@ -186,7 +183,6 @@ class AttachmentsPreviewPresenter @AssistedInject constructor(
when (attachment) { when (attachment) {
is Attachment.Media -> { is Attachment.Media -> {
temporaryUriDeleter.delete(attachment.localMedia.uri) temporaryUriDeleter.delete(attachment.localMedia.uri)
preProcessingJob?.cancel()
mediaUploadInfo.dataOrNull()?.let { data -> mediaUploadInfo.dataOrNull()?.let { data ->
cleanUp(data) cleanUp(data)
} }