Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Avoid creating a Json instance many times.

Browse source
This commit is contained in:
Benoit Marty 2025-10-20 09:35:12 +02:00 • committed by Benoit Marty
parent 241a968d66
commit ab35235bae
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/WebViewAudioManager.kt
View file

@ -44,6 +44,13 @@ class WebViewAudioManager(
private val coroutineScope: CoroutineScope, private val coroutineScope: CoroutineScope,
private val onInvalidAudioDeviceAdded: (InvalidAudioDeviceReason) -> Unit, private val onInvalidAudioDeviceAdded: (InvalidAudioDeviceReason) -> Unit,
) { ) {
private val json by lazy {
Json {
encodeDefaults = true
explicitNulls = false
}
}
/** /**
* Whether to disable bluetooth audio devices. This must be done on Android versions lower than Android 12, * Whether to disable bluetooth audio devices. This must be done on Android versions lower than Android 12,
* since the WebView approach breaks when using the legacy Bluetooth audio APIs. * since the WebView approach breaks when using the legacy Bluetooth audio APIs.
@ -308,11 +315,7 @@ class WebViewAudioManager(
devices: List<SerializableAudioDevice> = listAudioDevices().map(SerializableAudioDevice::fromAudioDeviceInfo), devices: List<SerializableAudioDevice> = listAudioDevices().map(SerializableAudioDevice::fromAudioDeviceInfo),
) { ) {
Timber.d("Updating available audio devices") Timber.d("Updating available audio devices")
val jsonSerializer = Json { val deviceList = json.encodeToString(devices)
encodeDefaults = true
explicitNulls = false
}
val deviceList = jsonSerializer.encodeToString(devices)
webView.evaluateJavascript("controls.setAvailableOutputDevices($deviceList);", { webView.evaluateJavascript("controls.setAvailableOutputDevices($deviceList);", {
Timber.d("Audio: setAvailableOutputDevices result: $it") Timber.d("Audio: setAvailableOutputDevices result: $it")
}) })