Remove Modifier parameter in private function when only default value is used.

This will improve the code coverage metrics, and this also fixes a few potential bug, where the Modifier was used several times.

features/lockscreen/impl/src/main/kotlin/io/element/android/features/lockscreen/impl/components/PinEntryTextField.kt

@@ -66,10 +66,8 @@ fun PinEntryTextField(
 private fun PinEntryRow(
     pinEntry: PinEntry,
     isSecured: Boolean,
-    modifier: Modifier = Modifier,
 ) {
     FlowRow(
-        modifier = modifier,
         horizontalArrangement = Arrangement.spacedBy(8.dp, alignment = Alignment.CenterHorizontally),
         verticalArrangement = Arrangement.spacedBy(8.dp),
     ) {
@@ -83,7 +81,6 @@ private fun PinEntryRow(
 private fun PinDigitView(
     digit: PinDigit,
     isSecured: Boolean,
-    modifier: Modifier = Modifier,
 ) {
     val shape = RoundedCornerShape(8.dp)
     val appearanceModifier = when (digit) {
@@ -95,7 +92,7 @@ private fun PinDigitView(
         }
     }
     Box(
-        modifier = modifier
+        modifier = Modifier
             .size(48.dp)
             .then(appearanceModifier),
         contentAlignment = Alignment.Center,

features/lockscreen/impl/src/main/kotlin/io/element/android/features/lockscreen/impl/setup/biometric/SetupBiometricView.kt

@@ -57,13 +57,12 @@ fun SetupBiometricView(
 }
 
 @Composable
-private fun SetupBiometricHeader(modifier: Modifier = Modifier) {
+private fun SetupBiometricHeader() {
     val biometricAuth = stringResource(id = R.string.screen_app_lock_biometric_authentication)
     IconTitleSubtitleMolecule(
         iconImageVector = Icons.Default.Fingerprint,
         title = stringResource(id = R.string.screen_app_lock_settings_enable_biometric_unlock),
         subTitle = stringResource(id = R.string.screen_app_lock_setup_biometric_unlock_subtitle, biometricAuth),
-        modifier = modifier
     )
 }
 
@@ -71,11 +70,8 @@ private fun SetupBiometricHeader(modifier: Modifier = Modifier) {
 private fun SetupBiometricFooter(
     onAllowClicked: () -> Unit,
     onSkipClicked: () -> Unit,
-    modifier: Modifier = Modifier
 ) {
-    ButtonColumnMolecule(
-        modifier = modifier,
-    ) {
+    ButtonColumnMolecule {
         val biometricAuth = stringResource(id = R.string.screen_app_lock_biometric_authentication)
         Button(
             text = stringResource(id = R.string.screen_app_lock_setup_biometric_unlock_allow_title, biometricAuth),

features/lockscreen/impl/src/main/kotlin/io/element/android/features/lockscreen/impl/setup/pin/SetupPinView.kt

@@ -86,10 +86,8 @@ fun SetupPinView(
 private fun SetupPinHeader(
     isValidationStep: Boolean,
     appName: String,
-    modifier: Modifier = Modifier,
 ) {
     Column(
-        modifier = modifier,
         horizontalAlignment = Alignment.CenterHorizontally,
     ) {
         IconTitleSubtitleMolecule(
@@ -107,7 +105,6 @@ private fun SetupPinHeader(
 @Composable
 private fun SetupPinContent(
     state: SetupPinState,
-    modifier: Modifier = Modifier,
 ) {
     val focusRequester = remember { FocusRequester() }
     LaunchedEffect(Unit) {
@@ -119,14 +116,13 @@ private fun SetupPinContent(
         onValueChange = { entry ->
             state.eventSink(SetupPinEvents.OnPinEntryChanged(entry, state.isConfirmationStep))
         },
-        modifier = modifier
+        modifier = Modifier
             .focusRequester(focusRequester)
             .padding(top = 36.dp)
             .fillMaxWidth()
     )
     if (state.setupPinFailure != null) {
         ErrorDialog(
-            modifier = modifier,
             title = state.setupPinFailure.title(),
             content = state.setupPinFailure.content(),
             onDismiss = {

features/lockscreen/impl/src/main/kotlin/io/element/android/features/lockscreen/impl/unlock/PinUnlockView.kt

@@ -107,10 +107,9 @@ fun PinUnlockView(
 private fun PinUnlockPage(
     state: PinUnlockState,
     isInAppUnlock: Boolean,
-    modifier: Modifier = Modifier
 ) {
     BoxWithConstraints {
-        val commonModifier = modifier
+        val commonModifier = Modifier
             .fillMaxSize()
             .systemBarsPadding()
             .imePadding()
@@ -188,7 +187,6 @@ private fun SignOutPrompt(
     isCancellable: Boolean,
     onSignOut: () -> Unit,
     onDismiss: () -> Unit,
-    modifier: Modifier = Modifier
 ) {
     if (isCancellable) {
         ConfirmationDialog(
@@ -196,14 +194,12 @@ private fun SignOutPrompt(
             content = stringResource(id = R.string.screen_app_lock_signout_alert_message),
             onSubmitClicked = onSignOut,
             onDismiss = onDismiss,
-            modifier = modifier,
         )
     } else {
         ErrorDialog(
             title = stringResource(id = R.string.screen_app_lock_signout_alert_title),
             content = stringResource(id = R.string.screen_app_lock_signout_alert_message),
             onDismiss = onSignOut,
-            modifier = modifier,
         )
     }
 }
@@ -258,9 +254,11 @@ private fun PinUnlockExpandedView(
 @Composable
 private fun PinDotsRow(
     pinEntry: PinEntry,
-    modifier: Modifier = Modifier,
 ) {
-    Row(modifier, horizontalArrangement = spacedBy(8.dp), verticalAlignment = Alignment.CenterVertically) {
+    Row(
+        horizontalArrangement = spacedBy(8.dp),
+        verticalAlignment = Alignment.CenterVertically,
+    ) {
         for (digit in pinEntry.digits) {
             PinDot(isFilled = digit is PinDigit.Filled)
         }
@@ -270,7 +268,6 @@ private fun PinDotsRow(
 @Composable
 private fun PinDot(
     isFilled: Boolean,
-    modifier: Modifier = Modifier,
 ) {
     val backgroundColor = if (isFilled) {
         ElementTheme.colors.iconPrimary
@@ -278,7 +275,7 @@ private fun PinDot(
         ElementTheme.colors.bgSubtlePrimary
     }
     Box(
-        modifier = modifier
+        modifier = Modifier
             .size(14.dp)
             .background(backgroundColor, CircleShape)
     )
@@ -290,7 +287,10 @@ private fun PinUnlockHeader(
     isInAppUnlock: Boolean,
     modifier: Modifier = Modifier,
 ) {
-    Column(modifier, horizontalAlignment = Alignment.CenterHorizontally) {
+    Column(
+        modifier = modifier,
+        horizontalAlignment = Alignment.CenterHorizontally,
+    ) {
         if (isInAppUnlock) {
             RoundedIconAtom(imageVector = Icons.Filled.Lock)
         } else {

features/lockscreen/impl/src/main/kotlin/io/element/android/features/lockscreen/impl/unlock/keypad/PinKeypad.kt

@@ -108,14 +108,13 @@ private fun PinKeypadRow(
     models: ImmutableList<PinKeypadModel>,
     onClick: (PinKeypadModel) -> Unit,
     pinKeySize: Dp,
-    modifier: Modifier = Modifier,
     horizontalArrangement: Arrangement.Horizontal = Arrangement.Start,
     verticalAlignment: Alignment.Vertical = Alignment.Top,
 ) {
     Row(
         horizontalArrangement = horizontalArrangement,
         verticalAlignment = verticalAlignment,
-        modifier = modifier.fillMaxWidth(),
+        modifier = Modifier.fillMaxWidth(),
     ) {
         val commonModifier = Modifier.size(pinKeySize)
         for (model in models) {