Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Revert unnecessary analytics refactor in voice message presenter

Browse source
This commit is contained in:
Gianluca Iavicoli 2026-03-27 21:18:55 +01:00
parent a6ce20662f
commit b6df9fe4d7
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/voicemessages/composer/DefaultVoiceMessageComposerPresenter.kt
View file

@ -153,7 +153,7 @@ class DefaultVoiceMessageComposerPresenter(
} }
} }
fun sendVoiceMessage(inReplyToEventId: EventId?, composerEvent: Composer) { fun sendVoiceMessage(inReplyToEventId: EventId?) {
val finishedState = recorderState as? VoiceRecorderState.Finished val finishedState = recorderState as? VoiceRecorderState.Finished
if (finishedState == null) { if (finishedState == null) {
val exception = VoiceMessageException.FileException("No file to send") val exception = VoiceMessageException.FileException("No file to send")
@ -166,7 +166,7 @@ class DefaultVoiceMessageComposerPresenter(
} }
isSending = true isSending = true
player.pause() player.pause()
analyticsService.capture(composerEvent) analyticsService.captureComposerEvent()
sessionCoroutineScope.launch { sessionCoroutineScope.launch {
val result = sendMessage( val result = sendMessage(
file = finishedState.file, file = finishedState.file,
@ -187,12 +187,11 @@ class DefaultVoiceMessageComposerPresenter(
is VoiceMessageComposerEvent.RecorderEvent -> handleVoiceMessageRecorderEvent(event.recorderEvent) is VoiceMessageComposerEvent.RecorderEvent -> handleVoiceMessageRecorderEvent(event.recorderEvent)
is VoiceMessageComposerEvent.PlayerEvent -> handleVoiceMessagePlayerEvent(event.playerEvent) is VoiceMessageComposerEvent.PlayerEvent -> handleVoiceMessagePlayerEvent(event.playerEvent)
is VoiceMessageComposerEvent.SendVoiceMessage -> { is VoiceMessageComposerEvent.SendVoiceMessage -> {
// Capture mode eagerly before any coroutine dispatch, since CloseSpecialMode // Capture reply info eagerly before any coroutine dispatch, since CloseSpecialMode
// may reset it before the coroutine runs. // may reset composerMode before the coroutine runs.
val inReplyToEventId = (messageComposerContext.composerMode as? MessageComposerMode.Reply)?.eventId val inReplyToEventId = (messageComposerContext.composerMode as? MessageComposerMode.Reply)?.eventId
val composerEvent = buildComposerEvent()
localCoroutineScope.launch { localCoroutineScope.launch {
sendVoiceMessage(inReplyToEventId, composerEvent) sendVoiceMessage(inReplyToEventId)
} }
} }
VoiceMessageComposerEvent.DeleteVoiceMessage -> { VoiceMessageComposerEvent.DeleteVoiceMessage -> {
@ -308,12 +307,14 @@ class DefaultVoiceMessageComposerPresenter(
return result return result
} }
private fun buildComposerEvent() = private fun AnalyticsService.captureComposerEvent() =
Composer( capture(
inThread = messageComposerContext.composerMode.inThread, Composer(
isEditing = messageComposerContext.composerMode.isEditing, inThread = messageComposerContext.composerMode.inThread,
isReply = messageComposerContext.composerMode.isReply, isEditing = messageComposerContext.composerMode.isEditing,
messageType = Composer.MessageType.VoiceMessage, isReply = messageComposerContext.composerMode.isReply,
messageType = Composer.MessageType.VoiceMessage,
)
) )
} }