Enable detekt rule UnusedPrivateMember and cleanup the code.

libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/EnsureFcmTokenIsRetrievedUseCase.kt

@@ -1,45 +0,0 @@
-/*
- * Copyright (c) 2023 New Vector Ltd
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package io.element.android.libraries.pushproviders.firebase
-
-import javax.inject.Inject
-
-// TODO
-class EnsureFcmTokenIsRetrievedUseCase @Inject constructor(
-//    private val unifiedPushHelper: UnifiedPushHelper,
-//    private val fcmHelper: FcmHelper,
-        // private val activeSessionHolder: ActiveSessionHolder,
-) {
-
-//    fun execute(pushersManager: PushersManager, registerPusher: Boolean) {
-//        if (unifiedPushHelper.isEmbeddedDistributor()) {
-//            fcmHelper.ensureFcmTokenIsRetrieved(pushersManager, shouldAddHttpPusher(registerPusher))
-//        }
-//    }
-
-    private fun shouldAddHttpPusher(registerPusher: Boolean) = if (registerPusher) {
-        /*
-        TODO EAx
-        val currentSession = activeSessionHolder.getActiveSession()
-        val currentPushers = currentSession.pushersService().getPushers()
-        currentPushers.none { it.deviceId == currentSession.sessionParams.deviceId }
-         */
-        true
-    } else {
-        false
-    }
-}

services/analyticsproviders/posthog/src/main/kotlin/io/element/android/services/analyticsproviders/posthog/PosthogAnalyticsProvider.kt

@@ -101,9 +101,11 @@ class PosthogAnalyticsProvider @Inject constructor(
      * We avoid sending nulls as part of the UserProperties as this will reset the values across all devices.
      * The UserProperties event has nullable properties to allow for clients to opt in.
      */
+    /*
     private fun Map<String, Any?>.toPostHogUserProperties(): Properties {
         return Properties().apply {
             putAll(this@toPostHogUserProperties.filter { it.value != null })
         }
     }
+     */
 }

tools/detekt/detekt.yml

@@ -13,8 +13,7 @@ style:
   FunctionOnlyReturningConstant:
     active: false
   UnusedPrivateMember:
-    # TODO Enable it
+    active: true
-    active: false
   UnusedParameter:
     # TODO Enable it
     active: false